Skip to content

Conversation

@Francisco-Gamino
Copy link
Contributor

Issue describing the changes in this PR

This PR contains the following changes:

  • Updated build.ps1 to generate the SBOM as part of the build process
    • Added $AddSBOM parameter switch to specify the generation of the manifest during the build
    • Added $SBOMUtilSASUrl parameter, which is a SAS url pointing to the location where the ManifestTool is located
    • Install Microsoft.ManifestTool.dll from the $SBOMUtilSASUrl (encrypted pipeline variable)
  • Install .Net 3.1 (the runtime is required by Microsoft.ManifestTool.dll)
  • Updated azure-pipelines.yml to pass the new parameters to the build.ps1

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@Francisco-Gamino
Copy link
Contributor Author

/cc @eliaslopezgt

@Francisco-Gamino Francisco-Gamino force-pushed the Francisco-Gamino/sbom-prototype branch from 7bccb56 to 04f1f0b Compare December 8, 2021 18:12
@Francisco-Gamino
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@michaelpeng36 michaelpeng36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Francisco-Gamino Francisco-Gamino merged commit 3dc5202 into dev Dec 8, 2021
Francisco-Gamino added a commit that referenced this pull request Dec 17, 2021
* Add SBOM task to generate manifest

* Update pipeline to generate manifest
Francisco-Gamino added a commit that referenced this pull request Dec 17, 2021
* Add SBOM task to generate manifest

* Update pipeline to generate manifest
Francisco-Gamino added a commit that referenced this pull request Dec 17, 2021
* Add SBOM task to generate manifest

* Update pipeline to generate manifest
Francisco-Gamino added a commit that referenced this pull request Dec 17, 2021
* Add SBOM task to generate manifest

* Update pipeline to generate manifest
Francisco-Gamino added a commit that referenced this pull request Dec 17, 2021
* Add SBOM generation as part of the build process (#716)

* Add SBOM task to generate manifest

* Update pipeline to generate manifest

* Update VM pool and images name (#718)

* Generate SBOM only for release builds (#720)

* Generate SBOM only for release builds

* Simplify logic to upload the nuget package for integration testing
Francisco-Gamino added a commit that referenced this pull request Dec 17, 2021
* Add SBOM task to generate manifest

* Update pipeline to generate manifest
Francisco-Gamino added a commit that referenced this pull request Dec 27, 2021
* Add SBOM generation as part of the build process (#716)

* Add SBOM task to generate manifest

* Update pipeline to generate manifest

* Update VM pool and images name (#718)

* Generate SBOM only for release builds (#720)

* Generate SBOM only for release builds

* Simplify the logic to determine if this is a release build

* Simplify logic to upload the nuget package for integration testing

* Obtain the branch name from BuildSourceBranch (#728)

* Update task condition boolean values to include single quotes (#731)
Francisco-Gamino added a commit that referenced this pull request Dec 27, 2021
* Add SBOM generation as part of the build process (#716)

* Add SBOM task to generate manifest

* Update pipeline to generate manifest

* Update VM pool and image name (#718)

* Generate SBOM only for release builds

* Publish the test results

* Copy package to ArtifactStagingDirectory

* Simplify logic to upload the nuget package for integration testing

* Install .Net 3.1 which is required by the Microsoft.ManifestTool.dll tool for release builds

* Update AspNetVNext value from https://dotnet.myget.org/ to https://www.myget.org/

* Fix CosmosDB E2E test

* Obtain the branch name from BuildSourceBranch (#728)

* Update task condition boolean values to include single quotes (#731)

* Update task condition boolean value to include single quotes
@Francisco-Gamino Francisco-Gamino deleted the Francisco-Gamino/sbom-prototype branch January 10, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants