Skip to content

Conversation

@Francisco-Gamino
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino commented Dec 17, 2021

Issue describing the changes in this PR

resolves #719

Cherry-picked #716, #718, #720, #728, #731 applicable changes to the v3.x/ps7 branch.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

Francisco-Gamino and others added 4 commits December 17, 2021 12:21
* Add SBOM task to generate manifest

* Update pipeline to generate manifest
* Generate SBOM only for release builds

* Simplify the logic to determine if this is a release build
Copy link
Contributor

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a simple cherry pick, so LGTM

@Francisco-Gamino
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@michaelpeng36 michaelpeng36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes requested, but the rest looks good to me.

Copy link
Contributor

@michaelpeng36 michaelpeng36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Francisco-Gamino Francisco-Gamino merged commit bce3a1b into v3.x/ps7 Dec 27, 2021
@Francisco-Gamino Francisco-Gamino deleted the Francisco-Gamino/generate-sbom-v3-ps7 branch January 10, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants