-
Notifications
You must be signed in to change notification settings - Fork 54
Port SBOM generation to v3.x/ps6 #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port SBOM generation to v3.x/ps6 #726
Conversation
* Add SBOM task to generate manifest * Update pipeline to generate manifest
…tool for release builds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but I'd prefer if we could set the specific commit of the dotnet-install.ps1 resource that we're downloading. However, I also understand that this is a trusted resource, so I'll leave it up to you to make that change if you think it's worth it.
Also, before merge, let's make sure the CI tests pass :)
michaelpeng36
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue describing the changes in this PR
resolves #721
Cherry-picked #716, #718, #720, #728, #731 applicable changes to the
v3.x/ps6branch.Pull request checklist
release_notes.mdAdditional information
Additional PR information