Skip to content

Conversation

@Francisco-Gamino
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino commented Dec 17, 2021

Issue describing the changes in this PR

resolves #721

Cherry-picked #716, #718, #720, #728, #731 applicable changes to the v3.x/ps6 branch.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

Copy link
Contributor

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but I'd prefer if we could set the specific commit of the dotnet-install.ps1 resource that we're downloading. However, I also understand that this is a trusted resource, so I'll leave it up to you to make that change if you think it's worth it.

Also, before merge, let's make sure the CI tests pass :)

Copy link
Contributor

@michaelpeng36 michaelpeng36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Francisco-Gamino Francisco-Gamino merged commit 7302039 into v3.x/ps6 Dec 27, 2021
@Francisco-Gamino Francisco-Gamino deleted the Francisco-Gamino/generate-sbom-v3-ps6 branch January 10, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants