Skip to content

chore(builder): improvements #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 26, 2020
Merged

chore(builder): improvements #215

merged 5 commits into from
Feb 26, 2020

Conversation

sleepdefic1t
Copy link
Contributor

Summary

  • move Configuration argument to initial builder constructor.
  • enable passing Configuration arguments to the builder constructor.
  • cleanup builder calls in unit tests.
  • update documentation to match changes.
  • update the CHANGELOG.

Checklist

  • Documentation
  • Tests
  • Ready to be merged

@sleepdefic1t
chore(builder): move config to initial constructor
9ec1fd6 
- move network configuration to the initial builder constructor.
  - e.g. `builder::Transfer().build(config);` -> `builder::Transfer(config).build();`
- update unit test.
- update docs.
@sleepdefic1t
chore(builder): enable passing config arguments to builder
c1e2edb 
Enable passing Configuration constructor arguments to the builder constructor.

- rm `explicit` in `Configuration` constructors.
@sleepdefic1t
chore(builder): cleanup calls
fc733e4 
- rm unnecessary builder arguments from unit tests and documentation.
@sleepdefic1t
docs: update changelog
e4b0f8f
@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Feb 24, 2020
@codecov
Copy link

codecov bot commented Feb 24, 2020 •
edited
Loading

Codecov Report

Merging #215 into develop will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #215      +/-   ##
===========================================
+ Coverage    96.92%   97.09%   +0.17%     
===========================================
  Files           62       62              
  Lines         1170     1172       +2     
===========================================
+ Hits          1134     1138       +4     
+ Misses          36       34       -2
Impacted Files Coverage Δ
src/transactions/builders/common.hpp 100.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0746433...241e3ae. Read the comment docs.

@sleepdefic1t
Copy link
Contributor Author

@faustbrian
good to go 👍

@faustbrian faustbrian merged commit 2b07c52 into develop Feb 26, 2020
@ghost ghost deleted the chore(builder)/improvements branch February 26, 2020 14:21
@ghost ghost mentioned this pull request Mar 1, 2020
Closed
sleepdefic1t added a commit that referenced this pull request Mar 6, 2020
@sleepdefic1t
release: 1.1.0
44d47f7 
- added Delegate Resignation Builder and Tests [#207]
- improved transaction builder [#215]
- improved building as a project dependency [#206]
- make htlc claim secret a 32-byte hash [#212]
@sleepdefic1t sleepdefic1t mentioned this pull request Mar 6, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristjank kristjank Awaiting requested review from kristjank

1 more reviewer

@faustbrian faustbrian faustbrian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sleepdefic1t @faustbrian