Skip to content

chore(build): improve as dependency #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 24, 2020
Merged

chore(build): improve as dependency #206

merged 3 commits into from
Feb 24, 2020

Conversation

sleepdefic1t
Copy link
Contributor

Summary

Improve paths when building C++ Crypto as a project dependency.

  • CMAKE_SOURCE_DIR -> CMAKE_INSTALL_PREFIX
    • cmake/External.cmake ln#7, ln#41, ln#84, ln#118
    • src/CMakeLists.txt ln#10
  • add EXTERNAL_LIBRARY_INCLUDE var to link ArduinoJson lib.
    • cmake/External.cmake ln#161
    • src/CMakeLists.txt ln#131

Checklist

  • Ready to be merged

@sleepdefic1t
chore(build): improve as dependency
63e65b8 
Improve paths when building C++ Crypto as a project dependency.

- CMAKE_SOURCE_DIR -> CMAKE_INSTALL_PREFIX
  - `cmake/External.cmake` ln#7, ln#41, ln#84, ln#118
  - `src/CMakeLists.txt` ln#10
- add `EXTERNAL_LIBRARY_INCLUDE` var to link ArduinoJson lib.
  - `cmake/External.cmake` ln#161
  - `src/CMakeLists.txt` ln#131
@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Feb 21, 2020
@ghost ghost mentioned this pull request Feb 23, 2020
Closed
@sleepdefic1t
Copy link
Contributor Author

@faustbrian
This one’s good to go 👍

@faustbrian faustbrian merged commit 1183168 into ArkEcosystemArchive:develop Feb 24, 2020
@ghost ghost mentioned this pull request Mar 1, 2020
Closed
sleepdefic1t added a commit that referenced this pull request Mar 6, 2020
@sleepdefic1t
release: 1.1.0
44d47f7 
- added Delegate Resignation Builder and Tests [#207]
- improved transaction builder [#215]
- improved building as a project dependency [#206]
- make htlc claim secret a 32-byte hash [#212]
@sleepdefic1t sleepdefic1t mentioned this pull request Mar 6, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristjank kristjank Awaiting requested review from kristjank

1 more reviewer

@faustbrian faustbrian faustbrian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sleepdefic1t @faustbrian