Skip to content

feat(transactions): add delegate resignation builder and tests #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 22, 2020
Merged

feat(transactions): add delegate resignation builder and tests #207

merged 3 commits into from
Feb 22, 2020

Conversation

sleepdefic1t
Copy link
Contributor

Summary

  • add Delegate Resignation Builder file to /builders/ dir.
  • add Delegate Resignation header include to builder.hpp.
  • add Delegate Resignation unit test.
  • add Delegate Resignation definition file to Unit TestsCMakeLists.txt.
  • update the CHANGELOG.

Checklist

  • Tests
  • Ready to be merged

@sleepdefic1t
chore(transactions): add delegate resignation builder and tests
ce9a236 
- add Delegate Resignation header include to `builder.hpp`.
- add Delegate Resignation Builder file to `/builders/` dir.
- add Delegate Resignation unit test.
- add Delegate Resignation definition file to Unit Tests`CMakeLists.txt`.
- update the CHANGELOG.
@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Feb 21, 2020
@faustbrian faustbrian changed the title chore(transactions): add delegate resignation builder and tests feat(transactions): add delegate resignation builder and tests Feb 22, 2020
@faustbrian faustbrian merged commit b72fee5 into ArkEcosystemArchive:develop Feb 22, 2020
@sleepdefic1t sleepdefic1t deleted the chore(transactions)/add-delegate-resignation-builder branch February 23, 2020 00:15
@ghost ghost mentioned this pull request Feb 23, 2020
Closed
sleepdefic1t added a commit that referenced this pull request Mar 6, 2020
@sleepdefic1t
release: 1.1.0
44d47f7 
- added Delegate Resignation Builder and Tests [#207]
- improved transaction builder [#215]
- improved building as a project dependency [#206]
- make htlc claim secret a 32-byte hash [#212]
@sleepdefic1t sleepdefic1t mentioned this pull request Mar 6, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristjank kristjank Awaiting requested review from kristjank

1 more reviewer

@faustbrian faustbrian faustbrian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sleepdefic1t @faustbrian