-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Dwarf: implement .eh_frame #21210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dwarf: implement .eh_frame #21210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would make sense to land elf-incr branch first (#21212) in its current state since it cleans up a lot of things in the ELF linker, and then rebase this branch on top? Next, initSyntheticSections really should not be used in initMetadata - happy to clean that one up if you want. Finally, not a blocker but as it currently stands, .eh_frame generated with ZigObject will not have its CIEs deduped across all input object files - not a biggie, but something to remember about. I would also like to have it tested with the linker - emit .eh_frame section as part of .o file and then link it back into an executable.
A CIE is like 24 bytes, so it's definitely not worth deduping the two extra CIE per module in incremental mode (the only use case I'm working towards right now), especially given all the padding that already exists. The key feature that would be useful is the ability to generate a |
kubkon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
No description provided.