arch: stm32: gpio: give ability to set open-drain on pins #9834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@psidhu , please get CI passed so we can start the review. |
psidhu
force-pushed
the
pr-stm-gpio-drive-strengh
branch
from
9d66e8b to
448cc07
Compare
If user wants to configure different pin drive strengths for STM32 soc's, configure the pin to be open-drain. Signed-off-by: Pushpal Sidhu <[email protected]>
psidhu
force-pushed
the
pr-stm-gpio-drive-strengh
branch
from
448cc07 to
5f1d934
Compare
Contributor
Author
|
@erwango done. |
erwango
requested changes
Oct 8, 2018
Member
erwango
left a comment
erwango
left a comment
There was a problem hiding this comment.
One question (see comments) and one querry:
Since you're familiar with this piece of code now, can you factorize it into drivers/gpio/gpio_stm32.c (at least this function for now). I don't think there is a good reason to have this code duplicated across various stm32 series. Would be great. Thanks
| if (direction == GPIO_DIR_OUT) { | ||
| *pincfg = *pincfg | STM32_MODER_OUTPUT_MODE; | ||
|
|
||
| if (ds_low == GPIO_DS_ALT_LOW || |
Member
There was a problem hiding this comment.
I missing something here.
Can you explain why DS_ALT_LOW is equivalent to DS_DISCONNECT_HIGH and not DISCONNECT_LOW here?
Closed
Contributor
Author
Member
Contributor
Author
|
Closing this in lieu of #13190. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user wants to configure different pin drive strengths for STM32
soc's, configure the pin to be open-drain.