Skip to content

Conversation

@Benichou34
Copy link
Contributor

@Benichou34 Benichou34 commented Feb 8, 2019

Add ability to configure an output GPIO as Open Drain.
Add GPIO_OPEN_DRAIN flags for use with gpio_pin_configure.

@codecov-io
Copy link

codecov-io commented Feb 8, 2019

Codecov Report

Merging #13190 into master will decrease coverage by 4.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13190      +/-   ##
==========================================
- Coverage   53.05%   48.86%   -4.19%     
==========================================
  Files         313      317       +4     
  Lines       45706    46810    +1104     
  Branches    10584    10818     +234     
==========================================
- Hits        24248    22873    -1375     
- Misses      16547    19366    +2819     
+ Partials     4911     4571     -340
Impacted Files Coverage Δ
lib/libc/minimal/include/stdlib.h 0% <0%> (-100%) ⬇️
...ys/bluetooth/controller/ll_sw/nordic/lll/lll_adv.h 0% <0%> (-88%) ⬇️
subsys/bluetooth/controller/ll_sw/ull_slave.c 0% <0%> (-81.77%) ⬇️
...oth/controller/ll_sw/nordic/lll/lll_adv_internal.h 0% <0%> (-76.48%) ⬇️
.../bluetooth/controller/ll_sw/nordic/lll/lll_slave.c 0% <0%> (-65.52%) ⬇️
...ys/bluetooth/controller/ll_sw/nordic/lll/lll_adv.c 2.16% <0%> (-55.85%) ⬇️
subsys/bluetooth/controller/ll_sw/ull_adv.c 5.45% <0%> (-43.18%) ⬇️
subsys/net/ip/dhcpv4.c 6.14% <0%> (-35.39%) ⬇️
subsys/bluetooth/controller/ll_sw/ull_conn.c 16.67% <0%> (-33.4%) ⬇️
subsys/bluetooth/controller/ll_sw/ull_sched.c 50% <0%> (-33.34%) ⬇️
... and 199 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b21f3...4fe345a. Read the comment docs.

Copy link
Member

@mnkp mnkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zephyr aims to be compatible with Linux DTS. The relevant bindings for the GPIO node are defined in Linux's dt-bindings gpio.h. To fulfill this requirement the flag to configure open drain mode should be called GPIO_OPEN_DRAIN. gpio_stm32.c needs to be updated.

There is no need to modify include/dt-bindings/gpio/gpio.h file since there exists already PR #12651 which attempts to add the flag (along with several others).

Add ability to configure an output GPIO as Open Drain.
Add GPIO_OPEN_DRAIN flags for use with gpio_pin_configure.

Signed-off-by: Benoit Leforestier <[email protected]>
@Benichou34
Copy link
Contributor Author

Renamed GPIO_PUD_OPEN_DRAIN by GPIO_OPEN_DRAIN.
I waiting for PR #12651.

@erwango
Copy link
Member

erwango commented Jul 26, 2019

@Benichou34

I waiting for PR #12651.

PR #12651 has been closed. Any other plans vs current PR?

@Benichou34
Copy link
Contributor Author

Superseded by PR #16648

@Benichou34 Benichou34 closed this Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants