Skip to content

STM32: fix USB power-up sequence on STM32N6 #97805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2025
Merged

STM32: fix USB power-up sequence on STM32N6 #97805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1df2077
drivers: usb: udc: stm32: fix N6 power-up sequence logic
mathieuchopstm Oct 17, 2025
d50c9c3
drivers: usb: device: stm32: fix N6 power-up sequence logic
mathieuchopstm Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/usb/device/usb_dc_stm32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ static int usb_dc_stm32_phy_specific_clock_enable(const struct device *const clk
#elif DT_HAS_COMPAT_STATUS_OKAY(st_stm32n6_otghs)
/* Enable Vdd USB voltage monitoring */
LL_PWR_EnableVddUSBMonitoring();
while (__HAL_PWR_GET_FLAG(PWR_FLAG_USB33RDY)) {
while (!__HAL_PWR_GET_FLAG(PWR_FLAG_USB33RDY)) {
Copy link
Contributor

@FRASTM FRASTM Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also done with LL_PWR_IsActiveFlag_USB33RDY()

Copy link
Contributor Author

@mathieuchopstm mathieuchopstm Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't change the function used to minimize diff since this driver is legacy.

/* Wait for VDD33USB ready */
}
/* Enable VDDUSB */
Expand Down
6 changes: 3 additions & 3 deletions drivers/usb/udc/udc_stm32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1174,10 +1174,10 @@ static int priv_clock_enable(void)
}
#endif /* DT_HAS_COMPAT_STATUS_OKAY(st_stm32_otghs) */
#elif defined(CONFIG_SOC_SERIES_STM32N6X)
/* Enable Vdd USB voltage monitoring */
/* Enable Vdd33USB voltage monitoring */
LL_PWR_EnableVddUSBMonitoring();
while (__HAL_PWR_GET_FLAG(PWR_FLAG_USB33RDY)) {
/* Wait FOR VDD33USB ready */
while (!LL_PWR_IsActiveFlag_USB33RDY()) {
/* Wait for Vdd33USB ready */
}

/* Enable VDDUSB */
Expand Down