STM32: fix USB power-up sequence on STM32N6 #97805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually do what the comment says and wait for Vdd33USB to be ready, instead of waiting for the opposite. Signed-off-by: Mathieu Choplain <[email protected]>
Actually do what the comment says and wait for Vdd33USB to be ready, instead of waiting for the opposite. Signed-off-by: Mathieu Choplain <[email protected]>
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
jfischer-no,
marwaiehm-st and
tmon-nordic
|
erwango
approved these changes
Oct 17, 2025
FRASTM
reviewed
Oct 17, 2025
| /* Enable Vdd USB voltage monitoring */ | ||
| LL_PWR_EnableVddUSBMonitoring(); | ||
| while (__HAL_PWR_GET_FLAG(PWR_FLAG_USB33RDY)) { | ||
| while (!__HAL_PWR_GET_FLAG(PWR_FLAG_USB33RDY)) { |
There was a problem hiding this comment.
also done with LL_PWR_IsActiveFlag_USB33RDY()
There was a problem hiding this comment.
I didn't change the function used to minimize diff since this driver is legacy.
henrikbrixandersen
approved these changes
Oct 17, 2025
gautierg-st
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for Vdd33USB to be ready instead of the opposite.
Note: I have added a commit to fix the
devicedriver as my understanding is that fixes are still accepted? Let me know if that commit should be dropped.Fixes #97589