Skip to content

arch: riscv: Add support for Xuantie CPUs and enable it on bl61x #95427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2025
Merged

arch: riscv: Add support for Xuantie CPUs and enable it on bl61x #95427

merged 2 commits into from
Oct 8, 2025

Conversation

@VynDragon
Copy link
Contributor

@VynDragon VynDragon commented Sep 3, 2025 •
edited
Loading

needed for many things like DMA, flash access etc.

@VynDragon VynDragon force-pushed the bl61x_cache branch 2 times, most recently from 7f9e3dd to 53b9489 Compare September 3, 2025 17:18
@VynDragon VynDragon changed the title Introduce xtheadcmo extension cache management with bl61x example drivers: cache: Introduce xtheadcmo extension cache management with bl61x example Sep 3, 2025
@VynDragon VynDragon marked this pull request as ready for review September 4, 2025 01:31
@zephyrbot zephyrbot added area: Cache area: RISCV RISCV Architecture (32-bit & 64-bit) platform: Bouffalo Lab labels Sep 4, 2025
@nandojve nandojve changed the title drivers: cache: Introduce xtheadcmo extension cache management with bl61x example drivers: cache: bl61x: Introduce cache management Sep 4, 2025
nandojve
nandojve requested changes Sep 4, 2025
View reviewed changes
@VynDragon VynDragon force-pushed the bl61x_cache branch 2 times, most recently from cbae45a to 39d22f5 Compare September 4, 2025 17:53
@VynDragon VynDragon requested a review from nandojve September 4, 2025 18:01
@VynDragon
Copy link
Contributor Author

VynDragon commented Sep 4, 2025

rebased on main.

@nashif nashif assigned nashif and unassigned carlocaione Sep 5, 2025
@VynDragon VynDragon force-pushed the bl61x_cache branch 3 times, most recently from fcffa19 to 5568982 Compare September 18, 2025 22:11
JarmouniA
JarmouniA previously approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@JarmouniA JarmouniA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for bearing with me.

@VynDragon
Copy link
Contributor Author

VynDragon commented Sep 18, 2025

Thank you for taking the time to review and improve this.

@nandojve nandojve requested a review from nordicjm September 19, 2025 08:55
nandojve
nandojve previously approved these changes Sep 19, 2025
View reviewed changes
JarmouniA
JarmouniA reviewed Sep 19, 2025
View reviewed changes
@VynDragon
arch: riscv: Add support for Xuantie CPUs
51a0d82 
Adds some support for xuantie CPU, namely cache control

Signed-off-by: Camille BAUD <[email protected]>
@VynDragon
soc: bflb: Enable xuantie arch support for bl61x
48533ca 
Enables the Xuantie support for bl61x

Signed-off-by: Camille BAUD <[email protected]>
@VynDragon VynDragon dismissed stale reviews from nandojve and JarmouniA via 48533ca September 19, 2025 13:37
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 19, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@VynDragon VynDragon mentioned this pull request Sep 19, 2025
Merged
tejlmand
tejlmand approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, see detailed comment here: #95427 (comment)

@VynDragon VynDragon mentioned this pull request Oct 7, 2025
Open
@VynDragon VynDragon dismissed nordicjm’s stale review October 8, 2025 15:45

Issue is solved. Future update will apply recommendation that will come out of #97130. I have time today to work on other things dependent on rebasing on this PR so unblocking this.

@cfriedt cfriedt merged commit 4f3d385 into zephyrproject-rtos:main Oct 8, 2025
30 checks passed
@nordicjm
Copy link
Contributor

nordicjm commented Oct 9, 2025

Issue is solved. Future update will apply recommendation that will come out of #97130. I have time today to work on other things dependent on rebasing on this PR so unblocking this.

Sorry have been elsewhere, yes agreed on resolution

@nordicjm
Copy link
Contributor

nordicjm commented Oct 9, 2025

Though would just like to point out this https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#pr-technical-escalation

If no progress is made, the assignee (maintainer) has the right to dismiss stale, unrelated or irrelevant change requests by reviewers giving the reviewers a minimum of 1 business day to respond and revisit their initial change requests or start the escalation process.

The assignee has the responsibility to document the reasoning for dismissing any reviews in the PR and should notify the reviewer about their review being dismissed.

To give the reviewers time to respond and escalate, the assignee is expected to block the PR from being merged either by not approving the PR or by setting the DNM label.

So please do not dismiss unless you are the maintainer, and have followed the above

@VynDragon
Copy link
Contributor Author

VynDragon commented Oct 9, 2025 •
edited
Loading

In this specific case I am maintainer of the area the assignee isnt of anymore (and further PRs for bflb tend to get assigned to me), but yea I didnt mind that rule, my bad.

@VynDragon VynDragon deleted the bl61x_cache branch October 9, 2025 14:27
@nordicjm
Copy link
Contributor

nordicjm commented Oct 10, 2025

In this specific case I am maintainer of the area the assignee isnt of anymore (and further PRs for bflb tend to get assigned to me), but yea I didnt mind that rule, my bad.

Incorrect, arch/riscv is maintained as per https://github.com/zephyrproject-rtos/zephyr/blob/main/MAINTAINERS.yml#L4191 by fkokosinski, kgugala and tgorochowik, you are not a maintainer of that area

@VynDragon
Copy link
Contributor Author

VynDragon commented Oct 10, 2025 •
edited
Loading

Talking about bflb since this is a bflb pr but ok, whatever.

@VynDragon VynDragon mentioned this pull request Oct 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tejlmand tejlmand tejlmand approved these changes

@JarmouniA JarmouniA JarmouniA approved these changes

@nandojve nandojve nandojve approved these changes

@edersondisouza edersondisouza Awaiting requested review from edersondisouza

@fkokosinski fkokosinski Awaiting requested review from fkokosinski

@katsuster katsuster Awaiting requested review from katsuster

@kgugala kgugala Awaiting requested review from kgugala

@masz-nordic masz-nordic Awaiting requested review from masz-nordic

@mgielda mgielda Awaiting requested review from mgielda

@nashif nashif Awaiting requested review from nashif

@npitre npitre Awaiting requested review from npitre

@tgorochowik tgorochowik Awaiting requested review from tgorochowik

@ycsin ycsin Awaiting requested review from ycsin

@nordicjm nordicjm Awaiting requested review from nordicjm

Assignees

@nandojve nandojve

Labels

area: Cache area: RISCV RISCV Architecture (32-bit & 64-bit) platform: Bouffalo Lab

Projects

None yet

Milestone

v4.3.0

Development

Successfully merging this pull request may close these issues.

9 participants

@VynDragon @JarmouniA @nordicjm @nandojve @tejlmand @nashif @carlocaione @cfriedt @zephyrbot