toolchain: arcmwdt: override compiler_set_linker_properties #94983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template function to set linker properties by default doesn't work for ARC MWDT, whose compiler doesn't have the --print-libgcc-file-name flag. ARC MWDT doesn't set linker property lib_include_dir or rt_library. Signed-off-by: Lauren Murphy <[email protected]>
zephyrbot
requested review from
57300,
abrodkin,
evgeniy-paltsev,
jeremybettis,
nashif,
nordicjm,
stephanosio and
tejlmand
|
Contributor
|
Hi @laurenmurphyx64, |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template function to set linker properties by default doesn't work for ARC MWDT, whose compiler doesn't have the --print-libgcc-file-name flag. ARC MWDT doesn't set CMake linker property lib_include_dir or rt_library (and doesn't need them to be set either).
I am not one of the ARC MWDT maintainers or NSIM platform owners. I'm just submitting this just because our build is broken, and we'd like a fix to go in soon.