toolchain: arcmwdt: override unsuitable default implementations #94578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide toolchain-specific implementations for the new functions added in d77b58a, because the default ones end up with build failures. As the MWDT toolchain doesn't support different combinations of compilers and linkers, there's no need to pass any linker properties from the compiler, at least for the time being. Moreover, the default implementation of compiler_set_linker_properties() uses the compiler flag (--print-libgcc-file-name) that doesn't make any sense for MWDT. Therefore, provide an empty implementation of the function. The default implementation of toolchain_linker_add_compiler_options() doesn't cause any issues for now, but it's still better to replace it with the passthrough implementation borrowed from ld/lld. Signed-off-by: Ilya Tagunov <[email protected]>
zephyrbot
requested review from
57300,
abrodkin,
evgeniy-paltsev,
jeremybettis,
nashif,
nordicjm,
stephanosio and
tejlmand
|
keith-packard
approved these changes
Aug 17, 2025
Contributor
keith-packard
left a comment
keith-packard
left a comment
There was a problem hiding this comment.
These look good. The other linkers need help in multilib configurations as they can support non-default C libraries, so you shouldn't need the rt_library or lib_include_dir linker properties
ruuddw
approved these changes
Aug 18, 2025
Contributor
Author
|
Hi @tejlmand, could you please review this one? It's not possible to build Zephyr with MWDT toolchain right now because of the breakage this PR should fix. |
1 task
1 task
1 task
tejlmand
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide toolchain-specific implementations for the new functions added in d77b58a, because the default ones end up with build failures.
As the MWDT toolchain doesn't support different combinations of compilers and linkers, there's no need to pass any linker properties from the compiler, at least for the time being. Moreover, the default implementation of compiler_set_linker_properties() uses the compiler flag (--print-libgcc-file-name) that doesn't make any sense for MWDT. Therefore, provide an empty implementation of the function.
The default implementation of toolchain_linker_add_compiler_options() doesn't cause any issues for now, but it's still better to replace it with the passthrough implementation borrowed from ld/lld.
Fixes the build time failures introduced by #94359.