Skip to content

driver: video: remove endpoint id in esp32 driver #90090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025
Merged

driver: video: remove endpoint id in esp32 driver #90090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73e1f00
driver: video: remove endpoint id in esp32 driver
sylvioalves May 17, 2025
ac3cc76
tests: build_all: video: add esp32s3_eye board
sylvioalves May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/video/video_esp32_dvp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ static int video_esp32_get_caps(const struct device *dev, struct video_caps *cap
caps->min_line_count = caps->max_line_count = LINE_COUNT_HEIGHT;

/* Forward the message to the source device */
return video_get_caps(config->source_dev, ep, caps);
return video_get_caps(config->source_dev, caps);
}

static int video_esp32_get_fmt(const struct device *dev, struct video_format *fmt)
Expand Down
3 changes: 3 additions & 0 deletions tests/drivers/build_all/video/testcase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,6 @@ tests:
- arduino_nicla_vision/stm32h747xx/m7
extra_args:
- platform:stm32h7b3i_dk/stm32h7b3xx:SHIELD=st_b_cams_omv_mb1683
drivers.video.esp32_dvp.build:
platform_allow:
- esp32s3_eye/esp32s3/procpu
Comment on lines +31 to +33
Copy link
Contributor

@ngphibang ngphibang May 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we need to add the extra_args with an esp32 shield to get this tested in twister (because the device node is usually disabled by default and enabled in a separate shield). If it's the case, you can look at the ST platform example just above:

  drivers.video.stm32_dcmi.build:
    platform_allow:
      - stm32h7b3i_dk/stm32h7b3xx
      - arduino_nicla_vision/stm32h747xx/m7
    extra_args:
      - platform:stm32h7b3i_dk/stm32h7b3xx:SHIELD=st_b_cams_omv_mb1683

We can test this by making some wrong code in the driver and run twister to see if it can detect the error:

west twister -i -T tests/drivers/build_all/video

If it can, so that's fine.

Otherwise, if it takes time to do, we can merge the hot fix first then adding the test later in another PR. What do you think ?

Copy link
Contributor Author

@sylvioalves sylvioalves May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for shield or extra_args as I see. esp32s3_eye/esp32s3/procpu board is stand-alone. For testing porpuses with the device it would need extra .conf file though.

Copy link
Contributor Author

@sylvioalves sylvioalves May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is building successfully:
INFO - 617/954 esp32s3_eye/esp32s3/procpu drivers.video.esp32_dvp.build

Copy link
Contributor

@ngphibang ngphibang May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, tha'ts fine then. Thanks again !