Skip to content

drivers: ethernet: stm32: remove phy specific code #87593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 2, 2025
Merged

drivers: ethernet: stm32: remove phy specific code #87593

merged 9 commits into from
Apr 2, 2025

Conversation

@maass-hamburg
Copy link
Member

@maass-hamburg maass-hamburg commented Mar 24, 2025 •
edited
Loading

  • enable mdio also on legacy devices
  • remove phy specific code from stm32 ethernet driver
  • setting the phy-handle of the ethernac mac is now mandatory
  • phys, that don't use mdio or the standard registers can now be used.

@maass-hamburg maass-hamburg mentioned this pull request Mar 24, 2025
Merged
@maass-hamburg maass-hamburg force-pushed the stm32_ethernet_improve branch 3 times, most recently from 44412ae to 24d4c5b Compare March 25, 2025 10:05
@maass-hamburg maass-hamburg marked this pull request as ready for review March 25, 2025 10:10
@maass-hamburg maass-hamburg assigned erwango and unassigned pillo79 Mar 25, 2025
marwaiehm-st
marwaiehm-st reviewed Mar 25, 2025
View reviewed changes
@maass-hamburg maass-hamburg force-pushed the stm32_ethernet_improve branch from 24d4c5b to 60cc0af Compare March 25, 2025 12:30
marwaiehm-st
marwaiehm-st reviewed Mar 25, 2025
View reviewed changes
@maass-hamburg maass-hamburg force-pushed the stm32_ethernet_improve branch from 60cc0af to ac5451d Compare March 25, 2025 15:51
mathieuchopstm
mathieuchopstm reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I had something similar in stock (but not upstreamed); I have published the branch here if you want to take a look: https://github.com/mathieuchopstm/zephyr/tree/stm32_ethernet_rework

This branch is more conservative in terms of changes to the ETH driver, but uses some macrobatics in the MDIO driver to share the ETH_HandleTypeDef with its parent controller (saves RAM as the structure is quite large, but inhibits usage as a general-purpose MDIO; maybe an in-between solution could be found).

Another change I did was rename all "MDIO"-related stuff to clearly emphasize that this driver is for the MDIO controller built into the Ethernet IP (as opposed to the dedicated "general-purpose" MDIO controllers found on STM32H7) - this could be appreciated, but is mostly cosmetic, so not that important.

marwaiehm-st
marwaiehm-st reviewed Mar 25, 2025
View reviewed changes
mathieuchopstm
mathieuchopstm reviewed Mar 25, 2025
View reviewed changes
@maass-hamburg maass-hamburg force-pushed the stm32_ethernet_improve branch from f73739c to 11d3101 Compare March 31, 2025 14:50
@maass-hamburg
Copy link
Member Author

I checked HAL_ETH_Stop_IT in the HAL. It will only return HAL_ERROR, when heth->gState == HAL_ETH_STATE_STARTED is not true. In all other cases HAL_OK will be returned. That said, I prefer to not check the same value twice.

marwaiehm-st
marwaiehm-st previously approved these changes Apr 1, 2025
View reviewed changes
@maass-hamburg
drivers: mdio: stm32: add mdio for legacy api
192d4f5 
add mdio for legacy stm32 api

Signed-off-by: Fin Maaß <[email protected]>
@maass-hamburg
drivers: mdio: stm32: remove unused functions
a71edd8 
The api takes care, if the mdio bus_enable and bus_disable
are not needed, so there is no need to have tis in the driver.

Signed-off-by: Fin Maaß <[email protected]>
@maass-hamburg
boards: dts: stm32: add mdio and phy node
93d2c74 
add mdio and phy node to every stm32board that
supports ethernet.
Also set the phy-handle for every ethernet mac.

Signed-off-by: Fin Maaß <[email protected]>
@maass-hamburg
drivers: ethernet: stm32: make mac a child like the mdio node
18b9771 
mac and mdio are now on the same level, this way
phy-handle can be used.

Signed-off-by: Fin Maaß <[email protected]>
@maass-hamburg
drivers: ethernet: mdio: stm32: move stmmaceth clock to parent
df76c0a 
move stmmaceth clock to parent, so it can also be
used by mdio and rename it to ``stm-eth``.

Signed-off-by: Fin Maaß <[email protected]>
@maass-hamburg maass-hamburg force-pushed the stm32_ethernet_improve branch from 11d3101 to f098ec2 Compare April 1, 2025 13:32
mathieuchopstm
mathieuchopstm previously approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in current state. Very minor nits in the log messages:

erwango
erwango previously approved these changes Apr 1, 2025
View reviewed changes
@maass-hamburg
drivers: ethernet: stm32: remove internal phy code
d63dc68 
rewirte code and remove code that use internal phy functions.
A few Kconfig options got removed, that are now set by the
phy via the DT.

Signed-off-by: Fin Maaß <[email protected]>
@maass-hamburg
drivers: mdio: stm32: make driver more independent
04ede51 
make stm32 mdio driver more independent

Signed-off-by: Fin Maaß <[email protected]>
@maass-hamburg
drivers: mdio: stm32: set mdio clock for v1 api
a2270d4 
unfortunatly HAL_ETH_SetMDIOClockRange() isn't available
in the V1 API, so I had to copy the parts from the hal.

Signed-off-by: Fin Maaß <[email protected]>
@maass-hamburg
doc: update migration guide for stm32 ethernet driver
1175ae3 
update migration guide for changes of the
stm32 ethernet driver.

Signed-off-by: Fin Maaß <[email protected]>
@maass-hamburg maass-hamburg force-pushed the stm32_ethernet_improve branch from f098ec2 to 1175ae3 Compare April 1, 2025 16:25
@maass-hamburg
Copy link
Member Author

applied suggested changes by @mathieuchopstm

@kartben kartben merged commit abb1076 into zephyrproject-rtos:main Apr 2, 2025
25 checks passed
@maass-hamburg maass-hamburg mentioned this pull request Apr 17, 2025
Open
@rexut rexut mentioned this pull request May 2, 2025
Closed
@maass-hamburg maass-hamburg mentioned this pull request Sep 22, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwango erwango erwango approved these changes

@mathieuchopstm mathieuchopstm mathieuchopstm approved these changes

@marwaiehm-st marwaiehm-st marwaiehm-st approved these changes

@decsny decsny Awaiting requested review from decsny

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

@facchinm facchinm Awaiting requested review from facchinm

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@lmajewski lmajewski Awaiting requested review from lmajewski

@pdgendt pdgendt Awaiting requested review from pdgendt

@pillo79 pillo79 Awaiting requested review from pillo79

@fabiobaltieri fabiobaltieri Awaiting requested review from fabiobaltieri

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

@erwango erwango

Labels

area: Ethernet area: MDIO platform: STM32 ST Micro STM32 Release Notes To be mentioned in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@maass-hamburg @mathieuchopstm @marwaiehm-st @erwango @pillo79 @kartben @zephyrbot