Skip to content

Ethernet: Add support stm32n6570_dk #87562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2025
Merged

Ethernet: Add support stm32n6570_dk #87562

merged 2 commits into from
Apr 4, 2025

Conversation

@marwaiehm-st
Copy link
Contributor

@marwaiehm-st marwaiehm-st commented Mar 24, 2025 •
edited
Loading

Add ethernet node of stm32n6570_dk
Integrate GRMII and RMII interfaces

Based on this PR: #87593

@marwaiehm-st marwaiehm-st force-pushed the upstream_eth_disco_n6 branch 3 times, most recently from 264dc7a to 091627e Compare March 24, 2025 13:32
@maass-hamburg
Copy link
Member

maass-hamburg commented Mar 24, 2025 •
edited
Loading

instead of using and extending the internal eth_phy_get_link_state(), maybe use the phy_get_link_state() or even phy_link_callback_set() from the ethernet phy api. The later also has the benefit, that autonegation can be done on every change of the link not just on startup. the internal eth_phy_get_link_state() could still be used for the one that don't have a st,stm32-mdio

@maass-hamburg
Copy link
Member

maass-hamburg commented Mar 24, 2025

the st,stm32-mdio also uses only HAL_ETH_ReadPHYRegister() and HAL_ETH_WritePHYRegister() internally, like eth_phy_get_link_state(). That means, that eth_phy_get_link_state() can be fully replaced by the use of the ethernet phy api. It just have to make sure, that all soc, that select ETH_STM32_HAL_API_V2 also get the st,stm32-mdio dev. And all boards the also the generic ethernet-phy.

@maass-hamburg
Copy link
Member

maass-hamburg commented Mar 24, 2025

started something like I described there: #87593

@marwaiehm-st marwaiehm-st force-pushed the upstream_eth_disco_n6 branch 2 times, most recently from ee39d6c to 6d119f4 Compare March 26, 2025 14:44
@marwaiehm-st marwaiehm-st marked this pull request as ready for review March 26, 2025 15:56
@marwaiehm-st marwaiehm-st added the DNM This PR should not be merged (Do Not Merge) label Mar 26, 2025
@pillo79 pillo79 assigned erwango and unassigned pillo79 Mar 27, 2025
@marwaiehm-st marwaiehm-st force-pushed the upstream_eth_disco_n6 branch from 6d119f4 to 3656cfe Compare March 27, 2025 14:33
@marwaiehm-st marwaiehm-st force-pushed the upstream_eth_disco_n6 branch 3 times, most recently from 3238878 to 3197859 Compare March 27, 2025 15:05
erwango
erwango reviewed Mar 27, 2025
View reviewed changes
@marwaiehm-st marwaiehm-st force-pushed the upstream_eth_disco_n6 branch from 3197859 to a016e40 Compare March 28, 2025 13:29
@github-actions github-actions bot added the Release Notes To be mentioned in the release notes label Mar 28, 2025
@maass-hamburg
Copy link
Member

maass-hamburg commented Apr 2, 2025

@marwaiehm-st please rebase to current main, now that #87593 is merged

@marwaiehm-st marwaiehm-st force-pushed the upstream_eth_disco_n6 branch from a016e40 to 51bdac7 Compare April 2, 2025 08:57
@marwaiehm-st marwaiehm-st removed the DNM This PR should not be merged (Do Not Merge) label Apr 2, 2025
erwango
erwango reviewed Apr 2, 2025
View reviewed changes
@marwaiehm-st marwaiehm-st requested a review from erwango April 2, 2025 12:10
@decsny decsny removed their request for review April 2, 2025 15:57
maass-hamburg
maass-hamburg reviewed Apr 3, 2025
View reviewed changes
erwango
erwango reviewed Apr 3, 2025
View reviewed changes
@marwaiehm-st marwaiehm-st force-pushed the upstream_eth_disco_n6 branch from 09b9496 to 44f863d Compare April 3, 2025 20:46
erwango
erwango reviewed Apr 4, 2025
View reviewed changes
drivers/ethernet/eth_stm32_hal.c Outdated
Comment on lines 95 to 99
((DT_ENUM_HAS_VALUE(node_id, phy_connection_type, mii) ? ETH_MII_MODE : \
(DT_ENUM_HAS_VALUE(node_id, phy_connection_type, rmii) ? ETH_RMII_MODE : \
(DT_ENUM_HAS_VALUE(node_id, phy_connection_type, gmii) ? ETH_GMII_MODE : \
(DT_ENUM_HAS_VALUE(node_id, phy_connection_type, rgmii) ? ETH_RGMII_MODE : \
ETH_RMII_MODE)))))
Copy link
Member

@erwango erwango Apr 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since property is required, there is no need to default to ETH_RMII_MODE since there's already a check on ETH_RMII_MODE

Copy link
Contributor Author

@marwaiehm-st marwaiehm-st Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, we must have a default, so I deleted the check on RMII and kept the default.

@marwaiehm-st
boards: st: stm32n6570_dk: Add ethernet node
bac5f09 
Add the Ethernet MAC and MDIO nodes in the device tree.
Add Kconfig for Ethernet Support.

Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <[email protected]>
@marwaiehm-st
drivers: ethernet: Integrate GRMII and RMII interfaces
73d619c 
- Added macros `STM32_ETH_PHY_MODE`
  to determine the PHY mode (RGMII, GMII, RMII, and MII)
  from the `phy_connection_type` property in the device tree.
- Removed previous definitions for ETH_MEDIA_INTERFACE_MII
  and ETH_MEDIA_INTERFACE_RMII.
- Updated STM32_ETH_PHY_MODE macro to use ETH_MII_MODE
  and ETH_RMII_MODE.

Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <[email protected]>
@marwaiehm-st marwaiehm-st force-pushed the upstream_eth_disco_n6 branch from 44f863d to 73d619c Compare April 4, 2025 13:33
@github-actions github-actions bot requested a review from gautierg-st April 4, 2025 13:34
@kartben kartben merged commit 8db8591 into zephyrproject-rtos:main Apr 4, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwango erwango erwango approved these changes

@maass-hamburg maass-hamburg maass-hamburg approved these changes

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

@facchinm facchinm Awaiting requested review from facchinm

@FRASTM FRASTM Awaiting requested review from FRASTM

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@lmajewski lmajewski Awaiting requested review from lmajewski

@mathieuchopstm mathieuchopstm Awaiting requested review from mathieuchopstm

@pdgendt pdgendt Awaiting requested review from pdgendt

@pillo79 pillo79 Awaiting requested review from pillo79

@fabiobaltieri fabiobaltieri Awaiting requested review from fabiobaltieri

@kartben kartben Awaiting requested review from kartben

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

Assignees

@erwango erwango

Labels

area: Ethernet area: MDIO platform: STM32 ST Micro STM32 Release Notes To be mentioned in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marwaiehm-st @maass-hamburg @erwango @pillo79 @kartben