Kconfig: Remove remaining redundant 'default n's in drivers/ #8586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Piggyback a missing 'source "drivers/gpio/Kconfig.imx"'. This file wasn't included anywhere previously. Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson <[email protected]>
ulfalizer
requested review from
MaureenHelm,
Vudentz,
anangl,
andrewboie,
erwango,
finikorg,
jfischer-no,
jhedberg,
jukkar,
mbolivar,
nashif,
sjanc and
tbursztyka
as code owners
ulfalizer
commented
Jun 27, 2018
|
|
||
| config IEEE802154_RAW_MODE | ||
| bool "Use IEEE 802.15.4 driver without the MAC stack" | ||
| default n if NET_L2_IEEE802154 |
Contributor
Author
There was a problem hiding this comment.
@tbursztyka Removing this is a no-op, but I'm not sure what this was meant to do. Just documentation?
Codecov Report
@@ Coverage Diff @@
## master #8586 +/- ##
=======================================
Coverage 64.17% 64.17%
=======================================
Files 429 429
Lines 41157 41157
Branches 6925 6925
=======================================
Hits 26413 26413
Misses 11587 11587
Partials 3157 3157Continue to review full report at Codecov.
|
erwango
approved these changes
Jun 29, 2018
anangl
approved these changes
Jul 2, 2018
andrewboie
approved these changes
Jul 3, 2018
jfischer-no
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the remaining redundant
default nproperties indrivers/, after #8577 and #8578. Felt a bit silly splitting it into a million separate PRs. I split it up per directory.The commit
drivers: gpio: Kconfig: Remove redundant 'default n' propertiesalso adds a missing
source "drivers/gpio/Kconfig.imx".Some commits also remove a few redundant
default ""onstringsymbols. The auto-generated Kconfig documentation now mentions the implicit default value for symbols/choices without defaults. See #8540.There's some discussion in #8577 already, so could continue there if there's objections or questions.