genrest: Mention implicit default values #8540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CC @carlescufi |
ulfalizer
force-pushed
the
genrest-implicit-defaults
branch
2 times, most recently
from
057c5ba to
57ecc6b
Compare
It's common for people to put in a 'default n' "just in case", because it might not be obvious that bool symbols implicitly default to 'n'. To make it clearer, mention the implicit default value on the reference pages of symbols without defaults. Also mention that choices without defaults default to the first (visible) symbol in the choice. Note: Adding to the confusion, Kconfig used to generate a '# CONFIG_FOO is not set' line for 'default n', but no output when there was no default. I changed that recently in both the C tools and Kconfiglib. There's no output either case now (unless the symbol is visible). Signed-off-by: Ulf Magnusson <[email protected]>
ulfalizer
force-pushed
the
genrest-implicit-defaults
branch
from
57ecc6b to
4197819
Compare
Codecov Report
@@ Coverage Diff @@
## master #8540 +/- ##
=======================================
Coverage 63.92% 63.92%
=======================================
Files 427 427
Lines 41100 41100
Branches 6939 6939
=======================================
Hits 26275 26275
Misses 11678 11678
Partials 3147 3147Continue to review full report at Codecov.
|
carlescufi
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common for people to put in a
default n"just in case", becauseit might not be obvious that
boolsymbols implicitly default ton. Tomake it clearer, mention the implicit default value on the reference
pages of symbols without defaults.
Also mention that choices without defaults default to the first
(visible) symbol in the choice.
Note: Adding to the confusion, Kconfig used to generate a
# CONFIG_FOO is not setline fordefault n, but no output when therewas no default. I changed that recently in both the C tools and
Kconfiglib. There's no output either case now (unless the symbol is
visible).