boards: renesas: Fixing the pinctrl for SPI on ek_ra8d1 #83522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: Renesas RA
zephyrbot
requested review from
KhiemNguyenT,
duynguyenxa,
soburi,
tbursztyka,
teburd and
thaoluonguw
khoa-nguyen-18
force-pushed
the
fix_spi_node
branch
from
9ff9469 to
dba1bce
Compare
Contributor
Author
|
The current push is just to correct the commit message. |
duynguyenxa
previously approved these changes
Jan 3, 2025
thaoluonguw
previously approved these changes
Jan 3, 2025
thaoluonguw
reviewed
Jan 3, 2025
Contributor
thaoluonguw
left a comment
thaoluonguw
left a comment
There was a problem hiding this comment.
@khoa-nguyen-18 : Please update copyright year for modified files.
Currently, the SPI pinctrl is incorrect for the spi0 node. In this PR (zephyrproject-rtos#77850), we changed the pinctrl number for SPI from spi0 to spi1, but we forgot to update the node name to spi1. This commit aims to fix: - Correct the pinctrl name for spi - Correct the spi node on ek_ra8d1.dts Signed-off-by: Khoa Nguyen <[email protected]>
Currently, the SPI pinctrl is incorrect for the spi0 node. In this PR (zephyrproject-rtos#77850), we changed the pinctrl number for SPI from spi0 to spi1, but we forgot to update the node name to spi1. This commit aims to: - Correct the spi node in test app spi_loopback for ek_ra8d1 Signed-off-by: Khoa Nguyen <[email protected]>
khoa-nguyen-18
dismissed stale reviews from thaoluonguw and duynguyenxa
via
c18fdda
khoa-nguyen-18
force-pushed
the
fix_spi_node
branch
from
dba1bce to
c18fdda
Compare
Contributor
Author
I have updated. Thank you |
tbursztyka
approved these changes
Jan 27, 2025
soburi
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the SPI pinctrl is incorrect for the spi0 node.
In this PR (#77850), we changed the pinctrl number for SPI from spi0 to spi1, but we forgot to update the node name to spi1.
This PR aims to fix this issue.