-
Notifications
You must be signed in to change notification settings - Fork 8.2k
drivers: ethernet: renesas: Support Renesas RA8 Ethernet driver #77850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: ethernet: renesas: Support Renesas RA8 Ethernet driver #77850
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
7f2c197 to
46a85e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too similar to the generic phy-connection-type. Also I don't think it's a good idea to have an enum of a bunch of different specific phy devices. The phy should be a separate node in DT if it is a separate device in hardware.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@decsny , Changed to phy-connection-type
dts/arm/renesas/ra/ra8/ra8x1.dtsi
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some info specific external phy doesn't belong in an soc devictree, unless that phy is embedded in the soc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@decsny , Thank you for you feedback, now we are using phy node
drivers/ethernet/eth_renesas_ra.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be using zephyr phy API in the driver, no new vendor hal phy apis please, users hate this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@decsny , Thank you for you feedback, we change to implement mdio driver and now is using phy API from Zephyr, could you please help to recheck
46a85e2 to
d34901d
Compare
e1e6740 to
9751913
Compare
Update hal_renesas new commit ID, in this version there are support for Ethernet and Ethernet phy in hal layer Signed-off-by: Duy Nguyen <[email protected]>
Add support for mdio driver for Renesas RA MCU series This support utilize the r_ether_phy driver in hal renesas to support mdio write and read function Signed-off-by: Duy Nguyen <[email protected]>
The ICS1894 phy AN_COMPLETE bit is latched high, this make the BMSR first read return incorrect status of the AN state, update one more BMSR read to ensure all latched bit is clear and BMSR return actual status of the phy chip Signed-off-by: Duy Nguyen <[email protected]>
This commit is to enable Ethernet drivers support on Renesas RA MCU, first target support is the Renesas RA8 series Signed-off-by: Duy Nguyen <[email protected]>
Enable Ethernet controller node and mdio node for RA boards. Add pinctl for mdio and Ethernet usage Signed-off-by: Duy Nguyen <[email protected]>
When publish message, the dup_flag is not intialize causing it to have random value and making the AWS MQTT broker to reject the message Add initialize dup_flag as 0 Signed-off-by: Duy Nguyen <[email protected]>
9751913 to
d9239c6
Compare
|
@soburi It's in good shape. Please take a look. |
Currently, the SPI pinctrl is incorrect for the spi0 node. In this PR (zephyrproject-rtos#77850), we changed the pinctrl number for SPI from spi0 to spi1, but we forgot to update the node name to spi1. This commit aims to fix: - Correct the pinctrl name for spi - Correct the spi node on ek_ra8d1.dts Signed-off-by: Khoa Nguyen <[email protected]>
Currently, the SPI pinctrl is incorrect for the spi0 node. In this PR (zephyrproject-rtos#77850), we changed the pinctrl number for SPI from spi0 to spi1, but we forgot to update the node name to spi1. This commit aims to: - Correct the spi node in test app spi_loopback for ek_ra8d1 Signed-off-by: Khoa Nguyen <[email protected]>
Currently, the SPI pinctrl is incorrect for the spi0 node. In this PR (#77850), we changed the pinctrl number for SPI from spi0 to spi1, but we forgot to update the node name to spi1. This commit aims to fix: - Correct the pinctrl name for spi - Correct the spi node on ek_ra8d1.dts Signed-off-by: Khoa Nguyen <[email protected]>
Currently, the SPI pinctrl is incorrect for the spi0 node. In this PR (#77850), we changed the pinctrl number for SPI from spi0 to spi1, but we forgot to update the node name to spi1. This commit aims to: - Correct the spi node in test app spi_loopback for ek_ra8d1 Signed-off-by: Khoa Nguyen <[email protected]>
Currently, the SPI pinctrl is incorrect for the spi0 node. In this PR (zephyrproject-rtos#77850), we changed the pinctrl number for SPI from spi0 to spi1, but we forgot to update the node name to spi1. This commit aims to fix: - Correct the pinctrl name for spi - Correct the spi node on ek_ra8d1.dts (cherry picked from commit 810ceb2) Original-Signed-off-by: Khoa Nguyen <[email protected]> GitOrigin-RevId: 810ceb2 Cr-Build-Id: 8724547022730561377 Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8724547022730561377 Copybot-Job-Name: zephyr-main-copybot-downstream Change-Id: I84e08cf6ffe94a2fb65afbf71d56abd868ec64ae Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/6205016 Tested-by: ChromeOS Prod (Robot) <[email protected]> Bot-Commit: ChromeOS Prod (Robot) <[email protected]> Commit-Queue: ChromeOS Prod (Robot) <[email protected]>
Currently, the SPI pinctrl is incorrect for the spi0 node. In this PR (zephyrproject-rtos#77850), we changed the pinctrl number for SPI from spi0 to spi1, but we forgot to update the node name to spi1. This commit aims to: - Correct the spi node in test app spi_loopback for ek_ra8d1 (cherry picked from commit 436a6d8) Original-Signed-off-by: Khoa Nguyen <[email protected]> GitOrigin-RevId: 436a6d8 Cr-Build-Id: 8724547022730561377 Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8724547022730561377 Copybot-Job-Name: zephyr-main-copybot-downstream Change-Id: I344be2d30b98399136af17321d81b0d5dd3212ef Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/6205017 Bot-Commit: ChromeOS Prod (Robot) <[email protected]> Commit-Queue: ChromeOS Prod (Robot) <[email protected]> Tested-by: ChromeOS Prod (Robot) <[email protected]>
This PR is to support Ethernet driver for the Renesas RA8 boards
The driver design is based on the using Ethernet and Ethernet PHY FSP driver from hal_renesas to implement.