Skip to content

Conversation

@thaoluonguw
Copy link
Contributor

@thaoluonguw thaoluonguw commented Sep 1, 2024

This PR is to support Ethernet driver for the Renesas RA8 boards
The driver design is based on the using Ethernet and Ethernet PHY FSP driver from hal_renesas to implement.

@zephyrbot
Copy link

zephyrbot commented Sep 1, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_renesas zephyrproject-rtos/hal_renesas@1032651 zephyrproject-rtos/hal_renesas@f77a850 zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_renesas DNM This PR should not be merged (Do Not Merge) labels Sep 1, 2024
@thaoluonguw thaoluonguw changed the title Support renesas ra8 ethernet drivers: ethernet: renesas: Support Renesas RA8 Ethernet driver Sep 1, 2024
@thaoluonguw thaoluonguw force-pushed the support_renesas_ra8_ethernet branch from 7f2c197 to 46a85e2 Compare September 23, 2024 18:18
@thaoluonguw thaoluonguw marked this pull request as ready for review September 23, 2024 18:21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too similar to the generic phy-connection-type. Also I don't think it's a good idea to have an enum of a bunch of different specific phy devices. The phy should be a separate node in DT if it is a separate device in hardware.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@decsny , Changed to phy-connection-type

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some info specific external phy doesn't belong in an soc devictree, unless that phy is embedded in the soc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@decsny , Thank you for you feedback, now we are using phy node

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be using zephyr phy API in the driver, no new vendor hal phy apis please, users hate this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@decsny , Thank you for you feedback, we change to implement mdio driver and now is using phy API from Zephyr, could you please help to recheck

@duynguyenxa duynguyenxa force-pushed the support_renesas_ra8_ethernet branch from 46a85e2 to d34901d Compare October 25, 2024 07:42
Update hal_renesas new commit ID, in this version there are
support for Ethernet and Ethernet phy in hal layer

Signed-off-by: Duy Nguyen <[email protected]>
Add support for mdio driver for Renesas RA MCU series
This support utilize the r_ether_phy driver in hal renesas
to support mdio write and read function

Signed-off-by: Duy Nguyen <[email protected]>
The ICS1894 phy AN_COMPLETE bit is latched high, this make the
BMSR first read return incorrect status of the AN state, update
one more BMSR read to ensure all latched bit is clear and BMSR
return actual status of the phy chip

Signed-off-by: Duy Nguyen <[email protected]>
This commit is to enable Ethernet drivers support on Renesas RA
MCU, first target support is the Renesas RA8 series

Signed-off-by: Duy Nguyen <[email protected]>
Enable Ethernet controller node and mdio node for RA boards.
Add pinctl for mdio and Ethernet usage

Signed-off-by: Duy Nguyen <[email protected]>
When publish message, the dup_flag is not intialize
causing it to have random value and making the AWS MQTT
broker to reject the message
Add initialize dup_flag as 0

Signed-off-by: Duy Nguyen <[email protected]>
@duynguyenxa duynguyenxa force-pushed the support_renesas_ra8_ethernet branch from 9751913 to d9239c6 Compare December 4, 2024 11:53
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Dec 4, 2024
@KhiemNguyenT
Copy link

@soburi It's in good shape. Please take a look.

@kartben kartben merged commit 689d1f2 into zephyrproject-rtos:main Dec 5, 2024
30 of 31 checks passed
khoa-nguyen-18 added a commit to renesas/zephyr that referenced this pull request Jan 3, 2025
Currently, the SPI pinctrl is incorrect for the spi0 node.
In this PR (zephyrproject-rtos#77850), we changed the pinctrl number for SPI
from spi0 to spi1, but we forgot to update the node name
to spi1.
This commit aims to fix:
- Correct the pinctrl name for spi
- Correct the spi node on ek_ra8d1.dts

Signed-off-by: Khoa Nguyen <[email protected]>
khoa-nguyen-18 added a commit to renesas/zephyr that referenced this pull request Jan 3, 2025
Currently, the SPI pinctrl is incorrect for the spi0 node.
In this PR (zephyrproject-rtos#77850), we changed the pinctrl number for SPI
from spi0 to spi1, but we forgot to update the node name
to spi1.
This commit aims to:
- Correct the spi node in test app spi_loopback for ek_ra8d1

Signed-off-by: Khoa Nguyen <[email protected]>
@thaoluonguw thaoluonguw deleted the support_renesas_ra8_ethernet branch January 22, 2025 05:53
kartben pushed a commit that referenced this pull request Jan 27, 2025
Currently, the SPI pinctrl is incorrect for the spi0 node.
In this PR (#77850), we changed the pinctrl number for SPI
from spi0 to spi1, but we forgot to update the node name
to spi1.
This commit aims to fix:
- Correct the pinctrl name for spi
- Correct the spi node on ek_ra8d1.dts

Signed-off-by: Khoa Nguyen <[email protected]>
kartben pushed a commit that referenced this pull request Jan 27, 2025
Currently, the SPI pinctrl is incorrect for the spi0 node.
In this PR (#77850), we changed the pinctrl number for SPI
from spi0 to spi1, but we forgot to update the node name
to spi1.
This commit aims to:
- Correct the spi node in test app spi_loopback for ek_ra8d1

Signed-off-by: Khoa Nguyen <[email protected]>
RuibinChang pushed a commit to RuibinChang/zephyr that referenced this pull request Feb 10, 2025
Currently, the SPI pinctrl is incorrect for the spi0 node.
In this PR (zephyrproject-rtos#77850), we changed the pinctrl number for SPI
from spi0 to spi1, but we forgot to update the node name
to spi1.
This commit aims to fix:
- Correct the pinctrl name for spi
- Correct the spi node on ek_ra8d1.dts

(cherry picked from commit 810ceb2)

Original-Signed-off-by: Khoa Nguyen <[email protected]>
GitOrigin-RevId: 810ceb2
Cr-Build-Id: 8724547022730561377
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8724547022730561377
Copybot-Job-Name: zephyr-main-copybot-downstream
Change-Id: I84e08cf6ffe94a2fb65afbf71d56abd868ec64ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/6205016
Tested-by: ChromeOS Prod (Robot) <[email protected]>
Bot-Commit: ChromeOS Prod (Robot) <[email protected]>
Commit-Queue: ChromeOS Prod (Robot) <[email protected]>
RuibinChang pushed a commit to RuibinChang/zephyr that referenced this pull request Feb 10, 2025
Currently, the SPI pinctrl is incorrect for the spi0 node.
In this PR (zephyrproject-rtos#77850), we changed the pinctrl number for SPI
from spi0 to spi1, but we forgot to update the node name
to spi1.
This commit aims to:
- Correct the spi node in test app spi_loopback for ek_ra8d1

(cherry picked from commit 436a6d8)

Original-Signed-off-by: Khoa Nguyen <[email protected]>
GitOrigin-RevId: 436a6d8
Cr-Build-Id: 8724547022730561377
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8724547022730561377
Copybot-Job-Name: zephyr-main-copybot-downstream
Change-Id: I344be2d30b98399136af17321d81b0d5dd3212ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/6205017
Bot-Commit: ChromeOS Prod (Robot) <[email protected]>
Commit-Queue: ChromeOS Prod (Robot) <[email protected]>
Tested-by: ChromeOS Prod (Robot) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants