Skip to content

boards: shields: st_b_lcd40_dsi1_mb1166: refactoring #77854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2024
Merged

boards: shields: st_b_lcd40_dsi1_mb1166: refactoring #77854

merged 1 commit into from
Sep 23, 2024

Conversation

@JarmouniA
Copy link
Contributor

@JarmouniA JarmouniA commented Sep 1, 2024 •
edited
Loading

Minimize code duplication chances when multiple boards will be added eventually as supporting the st_b_lcd40_dsi1_mb1166 display shield (as in #74646).

This change was suggested by @danieldegrasse in #74646 (comment).

@github-actions
Copy link

github-actions bot commented Sep 1, 2024

Hello @JarmouniA, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@JarmouniA JarmouniA marked this pull request as ready for review September 1, 2024 14:45
@zephyrbot zephyrbot added platform: STM32 ST Micro STM32 area: Shields Shields (add-on boards) labels Sep 1, 2024
erwango
erwango previously approved these changes Sep 2, 2024
View reviewed changes
danieldegrasse
danieldegrasse requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@danieldegrasse danieldegrasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on- there are a few additional things we need to do in order to make this shield definition generic across boards though, primarily to handle the touch IC

@JarmouniA JarmouniA mentioned this pull request Sep 3, 2024
Merged
@JarmouniA
boards: shields: st_b_lcd40_dsi1_mb1166: refactoring
aa00b7d 
Minimize code duplication chances when multiple boards will be added
eventually as supporting this shield.

Define an alias for board i2c node used by on-shield touch controller.

Move H747I-specific LVGL/display optimization options to a dedicated
defconfig file.

Signed-off-by: Abderrahmane Jarmouni <[email protected]>
@josuah josuah added area: Display area: LVGL Light and Versatile Graphics Library Support labels Sep 11, 2024
@JarmouniA
Copy link
Contributor Author

@danieldegrasse Could you please take another look, thanks!

danieldegrasse
danieldegrasse approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@danieldegrasse danieldegrasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this cleanup!

@JarmouniA
Copy link
Contributor Author

@kartben could you take a look? thanks!

@carlescufi carlescufi merged commit 330abc4 into zephyrproject-rtos:main Sep 23, 2024
@JarmouniA JarmouniA deleted the fix_mb1166_shield branch September 23, 2024 08:21
@JarmouniA JarmouniA mentioned this pull request Sep 23, 2024
Merged
@JarmouniA JarmouniA mentioned this pull request Oct 5, 2024
Closed
@JarmouniA JarmouniA mentioned this pull request Nov 20, 2024
Closed
@josuah josuah mentioned this pull request Apr 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josuah josuah josuah left review comments

@kartben kartben kartben approved these changes

@erwango erwango erwango approved these changes

@danieldegrasse danieldegrasse danieldegrasse approved these changes

@avisconti avisconti Awaiting requested review from avisconti

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

@mathieuchopstm mathieuchopstm Awaiting requested review from mathieuchopstm

Assignees

@kartben kartben

Labels

area: Display area: LVGL Light and Versatile Graphics Library Support area: Shields Shields (add-on boards) platform: STM32 ST Micro STM32

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JarmouniA @kartben @erwango @danieldegrasse @josuah @carlescufi @zephyrbot