Add st_b_lcd40_dsi1_mb1166 display shield support for stm32f769i_disco board #74646

ssekar15 · 2024-06-21T07:39:59Z

PR covers

Add mipi ltdc display shield support for stm32f769i_disco board
Replace direct hal api for ltdc block reset to zephyr reset api framework

dts/arm/st/f4/stm32f429.dtsi

danieldegrasse · 2024-06-22T03:04:14Z

boards/shields/st_b_lcd40_dsi1_mb1166/boards/stm32f769i_disco.overlay

If there are multiple ST boards that support the ST_B_LCD40_DSI1_MB1166 shield, then you might consider defining node labels for connectors (IE for the LTDC, MIPI DSI, and I2C connections). This has been done for some NXP supplied displays, see here:

zephyr/boards/shields/rk055hdmipi4ma0/rk055hdmipi4ma0.overlay

Line 1 in 59632d5

/*

. This avoids code duplication (for example, the display panel timings look the same as the ones here:

zephyr/boards/shields/st_b_lcd40_dsi1_mb1166/boards/st_b_lcd40_dsi1_mb1166/stm32h747i_disco_stm32h747xx_m7.overlay

Line 1 in 59632d5

/*

It seems this is already being done for the GPIO nexus node, so expanding this to the peripherals might be useful

Touch and display controller are part of shield overlay. If I'm not wrong not all the STM chipset has LTDC, so the panel display timings in ltdc node shall be in board overlay.

Sure, not all the STM SOCs will have an LTDC- this is the case with NXP's SOCs as well. In the case of NXP's displays, we sell multiple display modules that connect via a 40 pin FPC present on several of our evaluation kits to the module itself. The benefit here is that if we designed a new SOC with a DSI interface and added the same 40 pin connector, we could enable support for these displays by simply adding node definitions at the board level.

Beyond this, if a customer wanted to use this shield with their custom board, they would not need to modify Zephyr itself to add a new overlay (or duplicate the overlay definition for their board out of tree).

This is a core idea of a shield- not every evaluation kit supported by Zephyr has a SPI interface broken out to arduino headers, but those that do can use a large subset of all Zephyr shields without board specific configuration. Of course the scope of this shield would be more narrow (perhaps 2-3 boards), but I think the benefits to this approach still apply.

@ssekar15 see https://github.com/ajarmouni-st/zephyr_dev/tree/fix_mb1166_shield
@danieldegrasse is this more or less what you meant?

Sorry for the delayed response- yeah, this looks right to me. Essentially just refactor the shields to avoid duplicating things in board-specific shield overlays

boards/st/stm32f769i_disco/stm32f769i_disco.dts

boards/shields/st_b_lcd40_dsi1_mb1166/boards/stm32f769i_disco.conf

boards/st/stm32h747i_disco/stm32h747i_disco_stm32h747xx_m7.dts

boards/shields/st_b_lcd40_dsi1_mb1166/boards/stm32h747i_disco_stm32h747xx_m7.overlay

drivers/display/display_stm32_ltdc.c

boards/shields/st_b_lcd40_dsi1_mb1166/Kconfig.defconfig

Add support for STM32F7 MIPI DSI host driver. Signed-off-by: Saravanan Sekar <[email protected]>

Add bindings for pll-r used for DSI HOST peripheral byte clock. Signed-off-by: Saravanan Sekar <[email protected]>

Add pll-r clock used for DSI HOST peripheral byte clock. Signed-off-by: Saravanan Sekar <[email protected]>

Use common pin reference for STMicroelectronics B-LCD40-DSI1 shield from board header mapping. Signed-off-by: Saravanan Sekar <[email protected]>

Capacitive touch ft6202 is not part board, remove in board dts and move to panel st_b_lcd40_dsi1_mb1166 shield. Signed-off-by: Saravanan Sekar <[email protected]>

Add support for STMicroelectronics B-LCD40-DSI1 shield to stm32f769i_disco board. Default config for lvgl is adjusted to lower value to fix compilation issue on low memory footprint like stm32f769i_disco. region `IDT_LIST' overflowed by 121081 bytes bss ' will not fit in region `RAM' ld.bfd: region `RAM' overflowed by 1220664 bytes collect2: error: ld returned 1 exit status Signed-off-by: Saravanan Sekar <[email protected]>

Add disp_f769_disco board to platform-allow list for display sample tests with st_b_lcd40_dsi1_mb1166 shield. Signed-off-by: Saravanan Sekar <[email protected]>

ssekar15 · 2025-03-12T12:55:20Z

@ssekar15 Please rebase

done, please review.

JarmouniA · 2025-03-12T13:08:21Z

@ssekar15 Hello again from my personal account :) Has the shift issue on stm32f769i-disco been solved? I no longer have access to hardware to verify it.

Unfortunately no.. I have tried with offset and different setting but didn't work

@ssekar15 Was this resolved?

JarmouniA · 2025-03-12T13:18:04Z

boards/st/stm32h747i_disco/stm32h747i_disco_stm32h747xx_m7.dts

 	status = "okay";
 };

+qsh_030_i2c: &i2c4 {


Already exists below, was added in 330abc4

JarmouniA · 2025-03-12T13:20:59Z

boards/st/stm32f769i_disco/stm32f769i_disco.dts

 	};
 };

+qsh_030_i2c: &i2c4 {


Perhaps add this comment
/* alias used by display shields with touch control */

JarmouniA · 2025-03-12T13:23:10Z

boards/st/stm32f769i_disco/stm32f769i_disco.dts

Commit message is no longer accurate, touch controller node was already moved to shield overlay in a previous PR.

JarmouniA · 2025-03-12T13:24:47Z

boards/shields/st_b_lcd40_dsi1_mb1166/boards/st_b_lcd40_dsi1_mb1166/stm32f769i_disco.conf

@@ -0,0 +1,5 @@
+# Copyright (c) 2024 Linumiz


JarmouniA · 2025-03-12T13:27:10Z

samples/drivers/display/sample.yaml

      - CONFIG_SDL_DISPLAY=n
      - CONFIG_TEST=y
    tags: display
+  sample.display.max7219:


JarmouniA · 2025-03-12T13:34:52Z

samples/drivers/display/sample.yaml

+    harness: console
+    harness_config:
+      fixture: fixture_display
+  sample.display.st_b_lcd40_dsi1_mb1166:


sample.display.shield below already covers this shield with otm8009a panel controller, you should add stm32f769i_disco there.

JarmouniA · 2025-03-12T13:41:22Z

boards/st/stm32f769i_disco/doc/index.rst

+The STM32F769I Discovery kit has a dedicated DSI LCD connector **CN1**, where
+the MB1166 (B-LCD40-DSI1) display extension board can be mounted. Enable display
+support in Zephyr by adding the shield ``st_b_lcd40_dsi1_mb1166`` or
+``st_b_lcd40_dsi1_mb1166_a09`` to your build command, for example:


But you only added config file for revision with otm8009a .

github-actions · 2025-05-12T00:41:00Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

sonarqubecloud · 2025-05-27T06:54:32Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

zhang-wenchao · 2025-09-10T05:58:29Z

I own this board and am trying to enable support. What is the current status of this PR? Does it require further maintenance?

ssekar15 · 2025-09-10T07:14:38Z

I own this board and am trying to enable support. What is the current status of this PR? Does it require further maintenance?

We have this display shift problem, which I couldn't spare time on this.
#74646 (comment)

zhang-wenchao · 2025-09-10T09:06:17Z

I tested this PR and found that the screen displayed color cast and abnormal display orientation and the touch was not usable.

zhang-wenchao · 2025-09-10T09:07:16Z

I own this board and am trying to enable support. What is the current status of this PR? Does it require further maintenance?

We have this display shift problem, which I couldn't spare time on this. #74646 (comment)

I'll try my best, but I'm no expert.

zhang-wenchao · 2025-10-22T01:34:57Z

There is another PR that implements this feature.

erwango · 2025-10-22T08:11:50Z

There is another PR that implements this feature.

Thanks. Done by #95200. Closing

zephyrbot added area: Shields Shields (add-on boards) platform: STM32 ST Micro STM32 area: Display area: Devicetree Binding PR modifies or adds a Device Tree binding area: Clock Control labels Jun 21, 2024

zephyrbot requested review from FRASTM, GeorgeCGV, ajarmouni-st, avisconti, danieldegrasse, decsny, erwango, galak, gautierg-st, jfischer-no, kartben, marwaiehm-st and nordic-krch June 21, 2024 07:40

zephyrbot assigned kartben Jun 21, 2024

ssekar15 force-pushed the disp_f769_disco branch from b343eaf to 8ba69eb Compare June 21, 2024 13:55

danieldegrasse reviewed Jun 22, 2024

View reviewed changes

ssekar15 force-pushed the disp_f769_disco branch 2 times, most recently from 6ac49fc to 36d4ccf Compare June 26, 2024 08:44

ajarmouni-st suggested changes Jun 26, 2024

View reviewed changes

boards/st/stm32f769i_disco/stm32f769i_disco.dts Outdated Show resolved Hide resolved

ajarmouni-st suggested changes Jun 26, 2024

View reviewed changes

ajarmouni-st mentioned this pull request Jun 27, 2024

stm32: mipi-dsi on F4 and F7 #74938

Closed

ssekar15 force-pushed the disp_f769_disco branch from 36d4ccf to 8a331da Compare June 28, 2024 05:59

ssekar15 requested a review from ajarmouni-st June 28, 2024 06:01

ajarmouni-st suggested changes Jun 28, 2024

View reviewed changes

drivers/display/display_stm32_ltdc.c Outdated Show resolved Hide resolved

boards/shields/st_b_lcd40_dsi1_mb1166/Kconfig.defconfig Outdated Show resolved Hide resolved

ssekar15 force-pushed the disp_f769_disco branch from 8a331da to 6b80813 Compare June 28, 2024 12:45

ssekar15 added 9 commits March 12, 2025 18:18

dts: arm: st: Add STM32F7 DSI host driver

b739a26

Add support for STM32F7 MIPI DSI host driver. Signed-off-by: Saravanan Sekar <[email protected]>

dts: bindings: clock: Add pll-r for PLLDSICLK clock

5e57d84

Add bindings for pll-r used for DSI HOST peripheral byte clock. Signed-off-by: Saravanan Sekar <[email protected]>

boards: stm32f769i_disco: add pll-r for PLLDSICLK clock

8dc6ac6

Add pll-r clock used for DSI HOST peripheral byte clock. Signed-off-by: Saravanan Sekar <[email protected]>

boards: shield: add dsi-lcd display header mapping for stm32h747i_disco

0a2eac2

Use common pin reference for STMicroelectronics B-LCD40-DSI1 shield from board header mapping. Signed-off-by: Saravanan Sekar <[email protected]>

boards: stm32f769i_disco: remove capacitive touch ft6202

bae1cef

Capacitive touch ft6202 is not part board, remove in board dts and move to panel st_b_lcd40_dsi1_mb1166 shield. Signed-off-by: Saravanan Sekar <[email protected]>

samples: add disp_f769_disco to display samples with shield

f7b7bfd

Add disp_f769_disco board to platform-allow list for display sample tests with st_b_lcd40_dsi1_mb1166 shield. Signed-off-by: Saravanan Sekar <[email protected]>

samples: add disp_f769_disco to display samples with shield

d5a0771

Add disp_f769_disco board to platform-allow list for display sample tests with st_b_lcd40_dsi1_mb1166 shield. Signed-off-by: Saravanan Sekar <[email protected]>

samples: add disp_f769_disco to display samples with shield

8f03a5e

Add disp_f769_disco board to platform-allow list for display sample tests with st_b_lcd40_dsi1_mb1166 shield. Signed-off-by: Saravanan Sekar <[email protected]>

ssekar15 force-pushed the disp_f769_disco branch from 471d921 to 8f03a5e Compare March 12, 2025 12:49

ssekar15 requested a review from danieldegrasse March 12, 2025 12:55

JarmouniA requested changes Mar 12, 2025

View reviewed changes

github-actions bot added the Stale label May 12, 2025

github-actions bot closed this May 27, 2025

erwango reopened this May 27, 2025

github-actions bot removed the Stale label May 28, 2025

danieldegrasse modified the milestones: v4.2.0, v4.3.0 Jul 14, 2025

zhang-wenchao mentioned this pull request Sep 15, 2025

Addition of PLLSAI on STM32F4/F7 and enabling of LTDC/DSI on STM32F769I-disco board #95200

Merged

erwango closed this Oct 22, 2025

Add st_b_lcd40_dsi1_mb1166 display shield support for stm32f769i_disco board #74646

Add st_b_lcd40_dsi1_mb1166 display shield support for stm32f769i_disco board #74646

Uh oh!

Conversation

ssekar15 commented Jun 21, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ssekar15 commented Mar 12, 2025

Uh oh!

JarmouniA commented Mar 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 12, 2025

Uh oh!

sonarqubecloud bot commented May 27, 2025

Quality Gate passed

Uh oh!

zhang-wenchao commented Sep 10, 2025

Uh oh!

ssekar15 commented Sep 10, 2025

Uh oh!

zhang-wenchao commented Sep 10, 2025

Uh oh!

zhang-wenchao commented Sep 10, 2025

Uh oh!

zhang-wenchao commented Oct 22, 2025

Uh oh!

erwango commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants