Feature/frdm mcxn947 lvgl #74279
Feature/frdm mcxn947 lvgl #74279
Conversation
zephyrbot
requested review from
DerekSnell,
EmilioCBen,
avisconti,
butok,
danieldegrasse,
decsny,
dleach02,
erwango,
jfischer-no,
kartben,
mmahadevan108 and
yvanderv
There was a problem hiding this comment.
As is tradition when NXP comes up with a new display format, we need to determine if this is at all a standard pinout- my guess is no, since I've only seen the pinout used by this display on NXP- supplied displays like the LCD PAR. If so, we should name the shield identifiers appropriately- perhaps nxp_touch_panel_mipi_dbi_i2c? I don't want to use the name nxp_touch_panel_parallel_i2c, because we also have i2c connectors for parallel RGB displays on the RT10xx EVKs. I'm open to other suggestions for this name though.
There was a problem hiding this comment.
Thanks @danieldegrasse , will update. About the name nxp_touch_panel_mipi_dbi_i2c, my only question is, the i2c is not related to mipi_dbi, should we still include mipi_dbi in the name? thanks.
There was a problem hiding this comment.
I guess my reasoning is that we already use parallel for something else in NXP's display shield names (parallel RGB), so I'm not sure what to name these identifiers. I suggested mipi_dbi_i2c because to me it represents the interface type this connector is designed around (MIPI DBI 8080/6800 mode) and the fact this is an I2C sideband touch controller line on that connector. We could also call this nxp_8080_i2c_touch_panel or something similar- I just want to avoid ambiguity between this and other display interfaces with a I2C connection included
There was a problem hiding this comment.
We should not put this in a board overlay- instead, we should use a gpio nexus node, with a compatible appropriate for the connector we are describing (perhaps nxp_mipi_dbi_gpio?). For an example, see here: #72174
There was a problem hiding this comment.
Hi @danieldegrasse , I guess I should add a yaml for LCD-PAR-S035 connecter (including both the 8080 pin and I2C pin), is my understanding right?
Another question is, this LCD-PAR-S035 connecter is not a standard connecter, the name nxp_mipi_dbi_gpio might be too generic, is there some suggestion for the naming? thanks.
There was a problem hiding this comment.
The YAML only needs to define the GPIO pins not used directly by a peripheral- typically interrupt/reset pins are needed there. We do need a YAML for the LCD-PAR connector though. Not sure how best to name this- do we expect the LCD_PAR to be the only NXP display that uses this connector?
zejiang0jason
force-pushed
the
feature/frdm_mcxn947_lvgl
branch
from
9dead17 to
bda3b2d
Compare
zephyrbot
added
platform: NXP Drivers
|
hello @danieldegrasse , the code is updated following the comments, please help review, thanks. |
|
Please address the compliance issue |
- Currently this interface is used by panel LCD-PAR-S035 Signed-off-by: Jason Yu <[email protected]>
- Add touch info in dts - Add LVGL configuration Signed-off-by: Jason Yu <[email protected]>
- Enable the touch panel of lcd_par_s035 Signed-off-by: Jason Yu <[email protected]>
zejiang0jason
force-pushed
the
feature/frdm_mcxn947_lvgl
branch
from
bda3b2d to
a0b48f1
Compare
6 participants
Enable lvgl for frdm-mcxn947