boards: shields: add rk043fn02h_ct and rk043fn66hs_ctg shields #72174
Conversation
zephyrbot
added
area: Display
platform: NXP
zephyrbot
requested review from
DerekSnell,
EmilioCBen,
avisconti,
decsny,
dleach02,
erwango,
jfischer-no,
kartben,
mmahadevan108,
nashif and
yvanderv
danieldegrasse
force-pushed
the
feature/rk043-display-shields
branch
3 times, most recently
from
b8c916c to
70b1a9a
Compare
|
@DerekSnell can you verify on your HW? |
DerekSnell
left a comment
DerekSnell
left a comment
There was a problem hiding this comment.
@danieldegrasse and @dleach02 ,
This PR works well on my hardware. I tested with the following combinations:
mimxrt1050_evkboard withrk043fn02h_ctshieldmimxrt1060_evkbboard withrk043fn66hs_ctgshield
The doc page has some typos to fix for the build instructions. Otherwise, this looks good to me.
There was a problem hiding this comment.
| Set ``-DSHIELD=rk044fn02h_ct`` when you invoke ``west build``. For | |
| Set ``-DSHIELD=rk043fn02h_ct`` when you invoke ``west build``. For |
There was a problem hiding this comment.
| :shield: rk044fn02h_ct | |
| :shield: rk043fn02h_ct |
danieldegrasse
force-pushed
the
feature/rk043-display-shields
branch
from
70b1a9a to
60ddede
Compare
Thanks for catching these- both should be fixed now |
|
@kartben need your approval |
|
@kartben please give this attention or reassign it to someone else (me) |
danieldegrasse
dismissed stale reviews from MaureenHelm, dleach02, and DerekSnell
via
c1573f7
danieldegrasse
force-pushed
the
feature/rk043-display-shields
branch
from
60ddede to
c1573f7
Compare
zephyrbot
added
platform: NXP Drivers
|
@kartben need you to review Daniel's change. @MaureenHelm @DerekSnell please review as your approvals were dropped when @danieldegrasse addressed @kartben change request. |
MaureenHelm
left a comment
MaureenHelm
left a comment
There was a problem hiding this comment.
It seems we're inconsistent about whether the vendor should be followed by a comma or a dash in the gpio header bindings. But it looks strange not to have a comma
Add bindings for nxp display interfaces. These bindings describe the 6 and 40 pin FPC connectors used for displays on several NXP EVKs using gpio nexus nodes. Signed-off-by: Daniel DeGrasse <[email protected]>
Define parallel and i2c FPC display interfaces for the RT1060 EVK. These interfaces are used by multiple displays for the EVK. Signed-off-by: Daniel DeGrasse <[email protected]>
Add a shield for the RK043FN02H-CT panel, a Rocktech display panel with an FT5336 touch controller. This panel uses a 40+6 FPC interface for parallel displays, which is supported by many NXP iMX RT EVKs. Signed-off-by: Daniel DeGrasse <[email protected]>
Add a shield for the RK043FN66HS-CTG panel, a Rocktech display panel with an GT911 touch controller. This panel uses a 40+6 FPC interface for parallel displays, which is supported by many NXP iMX RT EVKs. Signed-off-by: Daniel DeGrasse <[email protected]>
Remove display definition for the RT1060 EVK. This display panel is now supported as the RK043FN02H-CT shield. Add this information to the documentation for the board, along with other tested shields. Signed-off-by: Daniel DeGrasse <[email protected]>
Add testcases for rk043fn02h_ct and rk043fn66hs_ctg shields to display and LVGL samples, so these testcases will be built by CI. Signed-off-by: Daniel DeGrasse <[email protected]>
danieldegrasse
force-pushed
the
feature/rk043-display-shields
branch
from
c1573f7 to
4231eab
Compare
Good point- both bindings have been updated to have a comma |
7 participants
Add
rk043fn02h_ctandrk043fn66hs_ctgshields. These shields both describe Rocktech panels available from NXP, and compatible with several NXP iMX RT EVKs using a FPC interface.Define nodelabel aliases for these FPC interfaces, and update the RT1060 EVK board definition to no longer define the RK043FN02H_CT as a panel at the board level (and use the shield instead)
Support for additional NXP EVKs (RT1064, RT1050, RT1040) will be added in follow up PRs.