Revert "boards: arm: Fix sensor shell sample for beagleconnect_freedo… #66400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartben
approved these changes
Dec 11, 2023
…m board" This reverts commit 3769938. Now that gpio_i2c_switch is upstream, this hack should be removed. This had the unintended effect of disabling the on-board sensors. The issue was that the board was merged before this driver was upstream, resulting in the issue this commit "fixed". This revert also does not move the bus driver under the controller used by the driver as the sensor bus I2C driver is not an I2C peripheral. See: * zephyrproject-rtos#64881 * zephyrproject-rtos#64693 * zephyrproject-rtos#65031 Signed-off-by: Jason Kridner <[email protected]>
jadonk
force-pushed
the
fix-sensor-shell-beagleconnect-freedom
branch
from
66b1d11 to
bda025c
Compare
vaishnavachath
approved these changes
Dec 12, 2023
cfriedt
approved these changes
Dec 12, 2023
cfriedt
reviewed
Dec 12, 2023
| #size-cells = <0>; | ||
| controller = <&i2c0>; | ||
| gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>; | ||
|
|
Member
There was a problem hiding this comment.
Ah, I see - yeah, this makes a bit more sense now. Thanks @jadonk !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…m board"
This reverts commit 3769938.
Now that gpio_i2c_switch is upstream, this hack should be removed. This had the unintended effect of disabling the on-board sensors. The issue was that the board was merged before this driver was upstream, resulting in the issue this commit "fixed".
This revert also does not move the bus driver under the controller used by the driver as the sensor bus I2C driver is not an I2C peripheral.
See: