boards: arm: Fix sensor shell sample for beagleconnect_freedom board #64881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 944ced6 enabled CONFIG_UART_CONSOLE=y for the beagleconnect_freedom board, which had the side effect of satisfying a required dependency for the sensor shell sample application and causing new build errors in the weekly full twister run. Fix the build errors by moving the board's light and humidity sensor nodes to be children of the I2C controller node. Signed-off-by: Maureen Helm <[email protected]>
Member
|
Hi @MaureenHelm . #64693 will also fix the sensor shell sample (just tried Moving the sensors to i2c nodes seem to disable the sensors rather than fix the actual problem. |
yperess
approved these changes
Nov 7, 2023
nashif
approved these changes
Nov 9, 2023
Ayush1325
added a commit
to Ayush1325/zephyr
that referenced
this pull request
Dec 8, 2023
zephyrproject-rtos#64881 breaks zephyrproject-rtos#64693 Instead of reverting, I thought it might be better to move the whole switch to i2c. Signed-off-by: Ayush Singh <[email protected]>
jadonk
added a commit
to beagleboard/zephyr
that referenced
this pull request
Dec 12, 2023
…m board" This reverts commit 3769938. Now that gpio_i2c_switch is upstream, this hack should be removed. This had the unintended effect of disabling the on-board sensors. The issue was that the board was merged before this driver was upstream, resulting in the issue this commit "fixed". This revert also does not move the bus driver under the controller used by the driver as the sensor bus I2C driver is not an I2C peripheral. See: * zephyrproject-rtos#64881 * zephyrproject-rtos#64693 * zephyrproject-rtos#65031 Signed-off-by: Jason Kridner <[email protected]>
carlescufi
pushed a commit
that referenced
this pull request
Dec 13, 2023
…m board" This reverts commit 3769938. Now that gpio_i2c_switch is upstream, this hack should be removed. This had the unintended effect of disabling the on-board sensors. The issue was that the board was merged before this driver was upstream, resulting in the issue this commit "fixed". This revert also does not move the bus driver under the controller used by the driver as the sensor bus I2C driver is not an I2C peripheral. See: * #64881 * #64693 * #65031 Signed-off-by: Jason Kridner <[email protected]>
coreboot-bot
pushed a commit
to coreboot/zephyr-cros
that referenced
this pull request
Dec 14, 2023
…m board" This reverts commit 3769938. Now that gpio_i2c_switch is upstream, this hack should be removed. This had the unintended effect of disabling the on-board sensors. The issue was that the board was merged before this driver was upstream, resulting in the issue this commit "fixed". This revert also does not move the bus driver under the controller used by the driver as the sensor bus I2C driver is not an I2C peripheral. See: * zephyrproject-rtos/zephyr#64881 * zephyrproject-rtos/zephyr#64693 * zephyrproject-rtos/zephyr#65031 (cherry picked from commit 547a75d) Original-Signed-off-by: Jason Kridner <[email protected]> GitOrigin-RevId: 547a75d Change-Id: Ib6a6a0f71d249bc19a312d469f6e41224b70524b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5119865 Reviewed-by: Yuval Peress <[email protected]> Tested-by: Yuval Peress <[email protected]> Commit-Queue: Yuval Peress <[email protected]> Tested-by: ChromeOS Prod (Robot) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 944ced6 enabled CONFIG_UART_CONSOLE=y for the beagleconnect_freedom board, which had the side effect of satisfying a required dependency for the sensor shell sample application and causing new build errors in the weekly full twister run. Fix the build errors by moving the board's light and humidity sensor nodes to be children of the I2C controller node.
cc: @Ayush1325 @jadonk
https://github.com/zephyrproject-rtos/zephyr/actions/runs/6758835093/job/18371014455#step:14:4966