pm: device: add driver init helper #60802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 26, 2023 09:03
Implement `gpio_pin_get_config` for the stellaris platform, and by extension `qemu_cortex_m3`. Signed-off-by: Jordan Yates <[email protected]>
Adds a helper function for initializing devices into the expected power state, through the devices `pm_device_action_cb_t`. This eliminates code duplication between the init functions and the PM callback. The expected device states in order of priority are: * No power applied to device, `OFF` * `zephyr,pm-device-runtime-auto` enabled, `SUSPEND` * Otherwise, `ACTIVE` Signed-off-by: Jordan Yates <[email protected]>
Let the driver compile without `PM_DEVICE_POWER_DOMAIN`, in which case the driver only controls the GPIO, without notifying dependant devices. Signed-off-by: Jordan Yates <[email protected]>
Startup power domains according to the expected final state given the power supply and PM device runtime support. Signed-off-by: Jordan Yates <[email protected]>
Update the expected power domain behaviour in the tests in line with the driver implementation changes. Signed-off-by: Jordan Yates <[email protected]>
Test that `pm_device_driver_init` puts devices into the appropriate state depending on the devicetree configuration. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
requested review from
MaureenHelm,
carlescufi,
ceolin,
galak,
mnkp and
nashif
as code owners
gmarull
approved these changes
Jul 26, 2023
tmleman
approved these changes
Jul 26, 2023
fabiobaltieri
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a helper function for initializing devices into the expected power
state, through the devices
pm_device_action_cb_t. This eliminates codeduplication between the init functions and the PM callback.
The expected device states in order of priority are:
OFFzephyr,pm-device-runtime-autoenabled,SUSPENDACTIVERe-opening reverted PR #60411, now that #60410 is merged and CI failures resolved