pm: device: add driver init helper #60411
Conversation
Generate a zero padded variant of `_ORD` that is suitable for use in linker scripts with the `SORT` property, so that `6` is correctly placed before `24`, and so on. Signed-off-by: Jordan Yates <[email protected]>
Add a sub-priority field to `Z_INIT_ENTRY_SECTION`, which is used to ensure that multiple drivers running at the same init priority still run in an order that respects their devicetree dependencies. This is primarily useful when multiple instances of the same device are instantiated that can depend on each other, for example power domains and i2c muxes. Signed-off-by: Jordan Yates <[email protected]>
Add tests for sorting devices at the same init priority based on their devicetree ordinals. Signed-off-by: Jordan Yates <[email protected]>
Implement `gpio_pin_get_config` for the stellaris platform, and by extension `qemu_cortex_m3`. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
requested review from
MaureenHelm,
andyross,
carlescufi,
ceolin,
dcpleung,
galak,
mbolivar-nordic,
mnkp,
nashif and
tbursztyka
as code owners
zephyrbot
requested review from
gmarull,
henrikbrixandersen,
peter-mitsis,
teburd and
tmleman
Adds a helper function for initializing devices into the expected power state, through the devices `pm_device_action_cb_t`. This eliminates code duplication between the init functions and the PM callback. The expected device states in order of priority are: * No power applied to device, `OFF` * `zephyr,pm-device-runtime-auto` enabled, `SUSPEND` * Otherwise, `ACTIVE` Signed-off-by: Jordan Yates <[email protected]>
Let the driver compile without `PM_DEVICE_POWER_DOMAIN`, in which case the driver only controls the GPIO, without notifying dependant devices. Signed-off-by: Jordan Yates <[email protected]>
Startup power domains according to the expected final state given the power supply and PM device runtime support. Signed-off-by: Jordan Yates <[email protected]>
Update the expected power domain behaviour in the tests in line with the driver implementation changes. Signed-off-by: Jordan Yates <[email protected]>
Test that `pm_device_driver_init` puts devices into the appropriate state depending on the devicetree configuration. Signed-off-by: Jordan Yates <[email protected]>
| if (rc == 0) { | ||
| rc = action_cb(dev, PM_DEVICE_ACTION_RESUME); | ||
| } | ||
| return rc; |
There was a problem hiding this comment.
This may be confusing, if the target is built without PM_DEVICE enabled, we don't have a struct pm_device associated with it and consequently no tracking of device power states. My take is that this exists to re-use the action callback and avoid code duplication. Which is a valid reason imho.
There was a problem hiding this comment.
blahh ... I've jumped into the changes before looking the pr message :)
erwango
left a comment
erwango
left a comment
There was a problem hiding this comment.
Some comments of someone that didn't followed power domains introduction and is trying to catch up.
There was a problem hiding this comment.
Not blocking but I feel not mentioning Power Domain in the test name makes it confusing.
| bool pm_device_is_powered(const struct device *dev); | ||
|
|
||
| /** | ||
| * @brief Setup a device driver into the lowest valid power mode |
There was a problem hiding this comment.
I think we can remove "valid" here (unless there are invalid power modes, but this should be defined).
This being said it is unclear to me what would be the lowest power mode for a device. If s2ram is supported, could it be device in ram retention ?
|
This should not have been merged due to the dependence on #60410 |
|
Sorry, I should have added a DNM label |
6 participants
Adds a helper function for initializing devices into the expected power
state, through the devices
pm_device_action_cb_t. This eliminates codeduplication between the init functions and the PM callback.
The expected device states in order of priority are:
OFFzephyr,pm-device-runtime-autoenabled,SUSPENDACTIVEDepends on #60410 (first 3 commits) to pass CI