modules: cmsis: move _glue_ code to modules/cmsis #59855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
manifest
manifest-cmsis
DNM
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
gmarull
requested review from
ABOSTM,
ChiHuaL,
FRASTM,
MaureenHelm,
MulinChao,
aescolar,
albertofloyd,
anangl,
andyross,
arnopo,
carlocaione,
dcpleung,
erwango,
fkokosinski,
galak,
ibirnbaum,
ioannisg,
kgugala,
microbuilder,
nashif,
simonguinot,
stephanosio and
wopu-ot
as code owners
carlescufi
previously approved these changes
Aug 23, 2023
Move CMSIS module Kconfig options to a folder, in preparation for CMSIS core header creation. Signed-off-by: Gerard Marull-Paretas <[email protected]>
The CMSIS module glue code was part of arch/ directory. Move it to modules/cmsis, and provide a single entry point for it: cmsis_core.h. This entry header will include the right CMSIS header (M or A/R). To make this change possible, CMSIS module Kconfig/CMake are declared as external, allowing us to add a new Zephyr include directory. All files including CMSIS have been updated. Signed-off-by: Gerard Marull-Paretas <[email protected]>
To ease migration of out-of-tree code, re-introduce previous CMSIS headers that when include generate a warning informing about the replacement header. Signed-off-by: Gerard Marull-Paretas <[email protected]>
CMSIS header is now generic. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Some files included <cmsis_core.h> for nothing, delete it. Signed-off-by: Gerard Marull-Paretas <[email protected]>
CMSIS header is now generic. Signed-off-by: Gerard Marull-Paretas <[email protected]>
gmarull
dismissed stale reviews from carlescufi, microbuilder, SgrrZhf, and carlocaione
via
31c17ea
gmarull
requested review from
SgrrZhf,
carlescufi,
carlocaione,
ifyall and
microbuilder
|
last push: updated module SHAs |
microbuilder
approved these changes
Aug 23, 2023
fabiobaltieri
approved these changes
Aug 23, 2023
carlescufi
approved these changes
Aug 24, 2023
hasheddan
added a commit
to hasheddan/wasm-micro-runtime
that referenced
this pull request
Nov 10, 2023
Fixes the import path for CMSIS in Zephyr versions > 3.4. See zephyrproject-rtos/zephyr#59855 for more information. Signed-off-by: Daniel Mangum <[email protected]>
hasheddan
added a commit
to hasheddan/wasm-micro-runtime
that referenced
this pull request
Nov 10, 2023
Fixes the import path for CMSIS in Zephyr versions > 3.4. See zephyrproject-rtos/zephyr#59855 for more information. Signed-off-by: Daniel Mangum <[email protected]>
wenyongh
pushed a commit
to bytecodealliance/wasm-micro-runtime
that referenced
this pull request
Nov 10, 2023
Fixes the import path for CMSIS in Zephyr versions > 3.4. See zephyrproject-rtos/zephyr#59855 for more information. Signed-off-by: Daniel Mangum <[email protected]>
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Fixes the import path for CMSIS in Zephyr versions > 3.4. See zephyrproject-rtos/zephyr#59855 for more information. Signed-off-by: Daniel Mangum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the CMSIS glue code to modules/cmsis. Refer to commits for more details.