spi: stm32: Correctly apply CPOL and CPHA settings #5462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPI_MODE_GET() returns a bitfield. It is thus wrong to test if a bit is set using the equality operator. The bit-wise AND operator must be used instead. This can be tested by setting the SPI in mode 3 (CPOL + CPHA). Currently both tests will fail and the result is a SPI configured in mode 0. This was confirmed using an oscilloscope. Applying the patch fixes the polarity. Signed-off-by: Florian Vaussard <[email protected]>
|
Commit 17f4dd8b6096946e56fb33b94d18dbb6a9bfdf05 in PR #5413 is already addressing the issue. |
ydamigos
approved these changes
Dec 21, 2017
|
@ydamigos Sorry I missed your patch, as the title of your PR was advertising only the F1 support. So you can disregard my PR. |
|
@vaussard it's my bad. I didn't update PR's message after pushing this commit. |
nashif
approved these changes
Dec 21, 2017
|
I removed the same change from PR #5413. |
erwango
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPI_MODE_GET() returns a bitfield. It is thus wrong to test if a bit is
set using the equality operator. The bit-wise AND operator must be used
instead.
This can be tested by setting the SPI in mode 3 (CPOL + CPHA). Currently
both tests will fail and the result is a SPI configured in mode 0. This
was confirmed using an oscilloscope. Applying the patch fixes the
polarity.