Skip to content

Initial support for EFR32BG22 #50352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Dec 20, 2022
Merged

Initial support for EFR32BG22 #50352

merged 17 commits into from
Dec 20, 2022

Conversation

@lpawelcz
Copy link
Contributor

@lpawelcz lpawelcz commented Sep 19, 2022 •
edited by mgielda
Loading

This PR supersedes PR #35361 and is a minimal version thereof. Its main purpose is to introduce basic support for the BRD4184B board using the EFR32BG22 SoC.

The PR consists of:

  • Pinctrl driver
  • Modifications to the UART driver
  • Sleep Timer (Real-Time Counter) driver and tests support
  • EFR32BG22 SoC support
  • EFR32BG22-SLTB010A board support

Initial support was verified on hardware by running the following samples:

  • hello_world
  • blinky
  • counter/alarm
  • subsys/shell/shell_module

This PR should be merged only after zephyrproject-rtos/hal_silabs#19 is merged and hal_silabs revision in west.yml is bumped to the newest one.

@zephyrbot zephyrbot added area: Pinctrl area: Devicetree area: UART Universal Asynchronous Receiver-Transmitter area: Counter platform: Silabs Silicon Labs labels Sep 19, 2022
@str4t0m
Copy link
Contributor

str4t0m commented Sep 19, 2022

@sateeshkotapati ping FYI

@zephyrbot zephyrbot added manifest west manifest-hal_silabs DNM This PR should not be merged (Do Not Merge) labels Sep 19, 2022
@zephyrbot
Copy link

zephyrbot commented Sep 19, 2022 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_silabs zephyrproject-rtos/hal_silabs@1ec8dd9 zephyrproject-rtos/hal_silabs@9dcaa76 (master) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

gmarull
gmarull requested changes Sep 19, 2022
View reviewed changes
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. PM code needs, at least, a better explanation.

@lpawelcz
Copy link
Contributor Author

lpawelcz commented Sep 21, 2022

@gmarull thank you for your review. I've already addressed most of the comments. After positive review I will squash fixes with initial set of commits from this PR.

@lpawelcz lpawelcz force-pushed the efr32bg22-initial branch 3 times, most recently from 4d9f82a to 5eba854 Compare September 26, 2022 09:38
@lpawelcz lpawelcz requested a review from mnkp as a code owner September 26, 2022 09:38
lpawelcz and others added 17 commits December 20, 2022 11:19
@lpawelcz
west.yml: hal_silabs: update hal version
ebcd3d3 
This bumps the hal_silabs in order to add initial support for
EFR32BG22 SoCs

Signed-off-by: Paweł Czarnecki <[email protected]>
@lpawelcz
soc: arm: silabs: remove soc_gpio_configure wrapper
7f0aae1 
It would be better to use GPIO_PinModeSet() functions directly
in the drivers.

Signed-off-by: Pawel Czarnecki <[email protected]>
@fkokosinski @msierszulski @lpawelcz
drivers: pinctrl: Add Silabs Gecko pin controller
2110d9d 
This commit adds initial support for gecko pinctrl driver

Co-authored-by: Mateusz Sierszulski <[email protected]>
Signed-off-by: Filip Kokosinski <[email protected]>
@fkokosinski @msierszulski @lpawelcz
drivers: serial: uart_gecko: Make driver dependent on pinctrl
6b16523 
This commit adds a series of driver-related changes to
Gecko pinctrl.

Co-authored-by: Mateusz Sierszulski <[email protected]>
Signed-off-by: Filip Kokosinski <[email protected]>
@msierszulski @fkokosinski @lpawelcz
drivers: counter: Add counter_gecko_stimer driver
029782a 
This commit adds initial support for Silabs Real-Time counter

Co-authored-by: Filip Kokosinski <[email protected]>
Signed-off-by: Mateusz Sierszulski <[email protected]>
@msierszulski @lpawelcz
samples: drivers: counter: support alarm sample in counter_gecko_stimer
8f9c0c4 
This commit adds sample support for the counter_gecko_stimer
driver.

Signed-off-by: Mateusz Sierszulski <[email protected]>
@msierszulski @lpawelcz
tests: drivers: counter: counter_basic_api support in counter_gecko_s…
587e897 
…timer

This commit adds test support for the counter_gecko_stimer
driver.

Signed-off-by: Mateusz Sierszulski <[email protected]>
@lpawelcz
drivers: gpio: gecko: initialize driver earlier
d04e580 
Common GPIO driver needs to be initialized before e.g UART driver
to ensure correct GPIO clock configuration when configuring UART pinout

Signed-off-by: Pawel Czarnecki <[email protected]>
@lpawelcz
drivers: gpio: gecko: enable GPIO clock
323a4bd 
Enable GPIO clock so that other drivers could
configure their I/O pins

Signed-off-by: Pawel Czarnecki <[email protected]>
@fkokosinski @msierszulski @lpawelcz
soc: silabs_exx32: Add support for SiLabs EFR32BG22 SoC
59dd2af 
This commit adds support for Silicon Labs EFR32BG22 SoC.

Co-authored-by: Mateusz Sierszulski <[email protected]>
Signed-off-by: Filip Kokosinski <[email protected]>
@fkokosinski @msierszulski @lpawelcz
boards: Add support for Silicon Labs EFR32BG22-SLTB010A board
852285d 
This commit adds support for Silicon Labs efr32bg22_sltb010a boardo

Co-authored-by: Mateusz Sierszulski <[email protected]>
Co-authored-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Filip Kokosinski <[email protected]>
Signed-off-by: Paweł Czarnecki <[email protected]>
@lpawelcz
dts: arm: silabs: efr32mg21: update peripheral reg addresses
b1c991d 
HAL update affects also EFR32MG21 SoC. Because of that we need to
update the reg addresses in DTS.

Signed-off-by: Pawel Czarnecki <[email protected]>
@lpawelcz
drivers: gpio: gecko: stop using deprecated function
e53054d 
change GPIO_IntConfig to GPIO_ExtIntConfig

Signed-off-by: Paweł Czarnecki <[email protected]>
@msierszulski @lpawelcz
drivers: hwinfo: Fix Gecko hwinfo driver building
55f5229 
do not build hwinfo driver for this board - it does not have support for it

Signed-off-by: Mateusz Sierszulski <[email protected]>
@lpawelcz
drivers: watchdog: silabs: include zephyr/irq.h
bfb9cd2 
Add missing include

Signed-off-by: Pawel Czarnecki <[email protected]>
@lpawelcz
dts: gpio: silabs: make peripheral-id optional
ad93178 
peripheral-id property should be eventually removed entirely.
For now set it as optional and allow skipping the usage
in GPIO driver.

Signed-off-by: Pawel Czarnecki <[email protected]>
@lpawelcz
dts: uart: silabs: make peripheral-id optional
35e2e85 
peripheral-id property should be eventually removed.
For now set it as optional and allow skipping the usage
in UART driver.

Signed-off-by: Pawel Czarnecki <[email protected]>
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Dec 20, 2022
@lpawelcz
Copy link
Contributor Author

lpawelcz commented Dec 20, 2022

Hi @gmarull, @cfriedt, @alexanderwachter. HAL PR has been merged. I rebased the PR and updated HAL sha in west.yml. Please take another look at this PR. Thank you!

cfriedt
cfriedt approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pointed out some required: false instances in Device Tree YAML, but not blocking. If you need to go through another rev then fix, otherwise, fix later.

dts/bindings/gpio/silabs,gecko-gpio-port.yaml
peripheral-id:
type: int
required: true
required: false
Copy link
Member

@cfriedt cfriedt Dec 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant - should have been caught by CI ..

dts/bindings/serial/silabs,gecko-usart.yaml
peripheral-id:
type: int
required: true
required: false
Copy link
Member

@cfriedt cfriedt Dec 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant as well.

@carlescufi carlescufi merged commit 0095eed into zephyrproject-rtos:main Dec 20, 2022
@stephanosio
Copy link
Member

stephanosio commented Dec 21, 2022

@lpawelcz This seems to have broken multiple networking tests: https://github.com/zephyrproject-rtos/zephyr/pull/52852/checks?check_run_id=10231260430. Can you provide a fix?

@cfriedt
Copy link
Member

cfriedt commented Dec 21, 2022

@stephanosio I'll take a look if nobody else is working on it atm

@lpawelcz
Copy link
Contributor Author

lpawelcz commented Dec 21, 2022

@stephanosio @cfriedt I have the fix already. Give me a second and I will open a PR

@lpawelcz lpawelcz mentioned this pull request Dec 21, 2022
Merged
@cfriedt cfriedt mentioned this pull request Dec 21, 2022
Closed
@tgorochowik tgorochowik deleted the efr32bg22-initial branch December 21, 2022 14:06
@fkokosinski fkokosinski mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fkokosinski fkokosinski fkokosinski left review comments

@dcpleung dcpleung dcpleung left review comments

@cfriedt cfriedt cfriedt approved these changes

@gmarull gmarull gmarull approved these changes

@alexanderwachter alexanderwachter alexanderwachter left review comments

@nashif nashif Awaiting requested review from nashif

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@carlescufi carlescufi Awaiting requested review from carlescufi

@galak galak Awaiting requested review from galak

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@ioannisg ioannisg Awaiting requested review from ioannisg

@chrta chrta Awaiting requested review from chrta

@ceolin ceolin Awaiting requested review from ceolin

@teburd teburd Awaiting requested review from teburd

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

@katsuster katsuster Awaiting requested review from katsuster

@martinjaeger martinjaeger Awaiting requested review from martinjaeger

@glaubermaroto glaubermaroto Awaiting requested review from glaubermaroto

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@pfalcon pfalcon Awaiting requested review from pfalcon

+2 more reviewers

@kmeinhar kmeinhar kmeinhar left review comments

@mbolivar-nordic mbolivar-nordic mbolivar-nordic left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area: Counter area: Devicetree Binding PR modifies or adds a Device Tree binding area: Devicetree area: GPIO area: HWINFO Hardware Information Driver area: Pinctrl area: Power Management area: UART Universal Asynchronous Receiver-Transmitter area: Watchdog Watchdog manifest manifest-hal_silabs platform: Silabs Silicon Labs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.