Skip to content

Conversation

@HaimYosefHaim
Copy link

Hi, to avoid updating the SDK version, I used the same version as in #19. I just added the relevant files of this SoC.

Copy link
Member

@fkokosinski fkokosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The licensing status of the files in the gecko/Device/SiliconLabs/EFM32PG22/Source/ is unclear to me, as there are two licenses mentioned in them (MSLA and Zlib). Are these files necessary for the SoC to be properly supported in Zephyr?

* The licensor of this software is Silicon Laboratories Inc. Your use of this
* software is governed by the terms of Silicon Labs Master Software License
* Agreement (MSLA) available at
* www.silabs.com/about-us/legal/master-software-license-agreement. This
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that only OSI-compliant licenses are allowed in Zephyr modules.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I removed unnecessary for current support in EFM32PG_DK2503A board I want to add

@fkokosinski
Copy link
Member

Hi @HaimYosefHaim, thanks for cleaning up the licensing status of this PR.

Usually when changes are made to a Zephyr HAL module repository, there exists an associated PR to the main Zephyr repo, so that maintainers can see how the changes in the HAL repository affect/are used in Zephyr itself. For an example, you could refer to zephyrproject-rtos/zephyr#50352.

It doesn't seem you have created one. Since you are adding support for EFM32PG22 SoCs, I assume you want to add a new board to Zephyr. Could you create a PR in Zephyr, so that I can verify how you are using files provided in this PR?

@jerome-pouiller
Copy link
Collaborator

jerome-pouiller commented Oct 1, 2024

Support for EFM32PG_DK2503A has never been submitted to the Zephyr repo. We can't merge this PR without the associated PR in Zephyr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants