Add buffered output support to console subsystem. #49
Conversation
nashif
added
the
In progress
|
This is "top-level goal" ticket for a number of other changes, e.g. No. 42, No. 43. In the present shape, it works only on STM32, and need further work as described in GH-3457 |
subsys/console/getchar.c
Outdated
|
(Un?)surprisingly this also works on frdm_k64f, which confirms there're wider problems than just stm32. (Or maybe not.) |
|
RFC on clarifying tx_ready vs tx_empty was posted: https://lists.zephyrproject.org/pipermail/zephyr-devel/2017-May/007642.html, and in its spirit, this patch was switched to tx_ready. Also, assuming that rx_ready can be edge interrupt, so its handler should try to read as much input as possible with uart_fifo_read(). In this shape, "echo" sample (included) was tested on: 96b_carbon, frdm_k64f, arduino_101, and behaves as expected. The debug output is still in this patch. Next step is to get feedback on RFC above, submit patch implementing it, and then finally this patch can be cleaned up. |
Signed-off-by: Paul Sokolovsky <[email protected]>
pfalcon
changed the title
|
With #159 being ready for merge, this patch has been cleaned up, and now should be ready for the final review too. @daniel-thompson , @galak , @tbursztyka , @erwango : Please review. |
|
@nashif : So, this mostly adds new functionality (with minor refactors) to the console subsystem, which was created by me in the first place. As a subsys maintainer I thus approve it ;-). If code looks ok for you, feel free to merge it. |
| * | ||
| * @return N/A | ||
| */ | ||
| void console_getchar_init(void); |
There was a problem hiding this comment.
Is there a concern about us removing an API, not sure if we can support a deprecated version or not?
There was a problem hiding this comment.
It was added in very this development cycle, so it was never released. As I mentioned in another comment, the whole "interrupt-driven console" subsystem is authored by me.
…ry-dep [util] Remove ARC code's dependency on JerryScript headers
Move the LLL-to-ULL Tx Ack queue API to ULL files. Fixes zephyrproject-rtos#49. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Move the LLL-to-ULL Tx Ack queue API to ULL files. Fixes #49. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Move the LLL-to-ULL Tx Ack queue API to ULL files. Fixes #49. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
5 participants
This implements completely interrupt-driven UART console in Zephyr.
The result of a number of patches to fix/cleanup/better define semantics of UART API in Zephyr.