boards: dts: nrf: Remove SoC compatible in top-level compatible #24774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SoC node has compatibles for the specific SoC in place, having the same compatible at the top level is technically a conflict and the top-level one should really just be about the board. Remove the SoC related compatibles at the top-level. Signed-off-by: Kumar Gala <[email protected]>
galak
requested review from
MaureenHelm,
aescolar,
carlescufi,
ioannisg,
lemrey,
nashif and
wopu-ot
as code owners
|
All checks passed. checkpatch (informational only, not a failure)Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
| / { | ||
| model = "QEMU Cortex-M0"; | ||
| compatible = "nordic,nrf51822-qfaa", "nordic,nrf51822"; | ||
| compatible = "bbc,qemu-microbit"; |
Member
There was a problem hiding this comment.
qemu_cortex_m0 is emulating a bbc-micro bit
Contributor
Author
There was a problem hiding this comment.
that's why I called in qemu-microbit, otherwise I'd argue we could have just used the microbit board port.
Member
There was a problem hiding this comment.
Yes. FWIW, the reason we did not use the microbit board port directly, is that QEMU does not emulate RTC but just the TIMER nRF peripheral, so we needed a new timer driver; this made me thing we could just have a separate qemu board with a local timer driver :)
mbolivar-nordic
approved these changes
Apr 28, 2020
Contributor
mbolivar-nordic
left a comment
mbolivar-nordic
left a comment
There was a problem hiding this comment.
Seems fine; AFAIK we don't use these anywhere
Contributor
Author
|
This isn't going to pass CI because of the large number of boards touched. As mentioned we don't use the top-level compat for anything so this will have no impact. Going to merge. |
Contributor
|
I love (not) when stuff that touches a bunch of files gets fast-tracked and merged with input from a small subset of those affected. First I saw of this was #24769 (review) and it was already too late. This removed compatibles at the root that are not present anywhere else: e.g. there's no longer a visible compatible to identify a It's not that it's a big deal, but I put that there for a reason, and now I need another solution. |
Contributor
|
I misread what this changed (it conflicted with a local change during rebase). Sorry, looks like this wasn't the cause of my problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SoC node has compatibles for the specific SoC in place, having the
same compatible at the top level is technically a conflict and the
top-level one should really just be about the board. Remove the SoC
related compatibles at the top-level.
Signed-off-by: Kumar Gala [email protected]