nrf: Add support for nrf52820 #24816

Mierunski · 2020-04-29T12:59:55Z

Add support for nrf52820 soc and emulated development for nrf52820 on nrf52833dk

zephyrbot · 2020-04-29T13:02:31Z

All checks passed.

checkpatch (informational only, not a failure)

-:122: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "nordic,nrf52833-dk-nrf52820" appears un-documented -- check ./dts/bindings/
#122: FILE: boards/arm/nrf52833dk_nrf52820/nrf52833dk_nrf52820.dts:12:
+	compatible = "nordic,nrf52833-dk-nrf52820";

-:409: WARNING:LONG_LINE_COMMENT: line over 80 characters
#409: FILE: dts/arm/nordic/nrf52820.dtsi:80:
+			/* uart can be either UART or UARTE, for the user to pick */

-:410: WARNING:LONG_LINE_COMMENT: line over 80 characters
#410: FILE: dts/arm/nordic/nrf52820.dtsi:81:
+			/* compatible = "nordic,nrf-uarte" or "nordic,nrf-uart"; */

-:632: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "nordic,nRF52820-QDAA" appears un-documented -- check ./dts/bindings/
#632: FILE: dts/arm/nordic/nrf52820_qdaa.dtsi:20:
+		compatible = "nordic,nRF52820-QDAA", "nordic,nRF52820", "nordic,nRF52", "simple-bus";

-:632: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "nordic,nRF52820" appears un-documented -- check ./dts/bindings/
#632: FILE: dts/arm/nordic/nrf52820_qdaa.dtsi:20:
+		compatible = "nordic,nRF52820-QDAA", "nordic,nRF52820", "nordic,nRF52", "simple-bus";

-:632: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "nordic,nRF52" appears un-documented -- check ./dts/bindings/
#632: FILE: dts/arm/nordic/nrf52820_qdaa.dtsi:20:
+		compatible = "nordic,nRF52820-QDAA", "nordic,nRF52820", "nordic,nRF52", "simple-bus";

-:632: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "simple-bus" appears un-documented -- check ./dts/bindings/
#632: FILE: dts/arm/nordic/nrf52820_qdaa.dtsi:20:
+		compatible = "nordic,nRF52820-QDAA", "nordic,nRF52820", "nordic,nRF52", "simple-bus";

-:632: WARNING:LONG_LINE: line over 80 characters
#632: FILE: dts/arm/nordic/nrf52820_qdaa.dtsi:20:
+		compatible = "nordic,nRF52820-QDAA", "nordic,nRF52820", "nordic,nRF52", "simple-bus";

- total: 0 errors, 8 warnings, 1328 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPDX_LICENSE_TAG SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

anangl · 2020-04-29T14:16:53Z

@Mierunski You need to add a change in west.yml that will point to pull/37/head as the hal_nordic module revision to be used. This way the changes from zephyrproject-rtos/hal_nordic#37 will be checked by CI.

dts/arm/nordic/nrf52820.dtsi

boards/arm/nrf52833dk_nrf52820/Kconfig.board

boards/arm/nrf52833dk_nrf52820/nrf52833dk_nrf52820.dts

boards/arm/nrf52833dk_nrf52820/Kconfig.board

boards/arm/nrf52833dk_nrf52820/Kconfig.defconfig

boards/arm/nrf52833dk_nrf52820/doc/index.rst

boards/arm/nrf52833dk_nrf52820/nrf52833dk_nrf52820.dts

soc/arm/nordic_nrf/nrf52/Kconfig.defconfig.nrf52820_QDAA

soc/arm/nordic_nrf/nrf52/Kconfig.soc

boards/arm/nrf52833dk_nrf52820/nrf52833dk_nrf52820.dts

boards/arm/nrf52833dk_nrf52820/nrf52833dk_nrf52820.yaml

dts/arm/nordic/nrf52820.dtsi

boards/arm/nrf52833dk_nrf52820/nrf52833dk_nrf52820.dts

west.yml

carlescufi · 2020-05-04T17:05:25Z

@Mierunski please rebase, the failure in CI was due to an unrelated issue

dts/arm/nordic/nrf52820.dtsi

soc/arm/nordic_nrf/nrf52/Kconfig.soc

dts/arm/nordic/nrf52820.dtsi

ioannisg

did a pass; no more comments except the one mentioned by @anangl and @sigurdnev

carlescufi · 2020-05-06T12:33:50Z

@Mierunski and @anangl if the nrfx update is backwards compatible, let's have it as its own, separate, first commit.

nvlsianpu · 2020-05-04T14:14:36Z

boards/arm/nrf52833dk_nrf52820/doc/index.rst

Does this mean I can develop using psychically nRF52833 SoC, as this is just trimmed down die? Or I should replace it?

Change west.yml nordic hal module to point to 2.2.0 nrfx version. Signed-off-by: Mieszko Mierunski <[email protected]>

soc/arm/nordic_nrf/nrf52/Kconfig.defconfig.nrf52820_QDAA

This commit adds basic support for nRF52820 SoC. Changes affect introducing: - architecuture files (dtsi) - configuration of nrfx drivers - adaptation of inclusions based on chosen SoC Signed-off-by: Mieszko Mierunski <[email protected]>

This commit adds support for nRF52820 development on nRF52833DK. Changes afffects: - Introduce files related to board description. - Add blank documentation file (for future update). - configuration files for build process. Signed-off-by: Mieszko Mierunski <[email protected]>

This commit adds support for bluetooth in nRF52820 SoC. Bluetooth radio related files created and added to Zephyr. Signed-off-by: Mieszko Mierunski <[email protected]>

ioannisg

Looks good to me, now, thanks @Mierunski

Mierunski · 2020-05-08T12:20:03Z

@ioannisg All green

Mierunski added area: Boards platform: nRF Nordic nRFx labels Apr 29, 2020

Mierunski requested review from anangl, carlescufi and ioannisg April 29, 2020 12:59

Mierunski requested review from lemrey and nashif as code owners April 29, 2020 12:59

zephyrbot added the area: Devicetree label Apr 29, 2020

carlescufi added this to the v2.3.0 milestone Apr 29, 2020

Mierunski force-pushed the nrf52820_support branch from 6bd4189 to bef7e4c Compare April 30, 2020 10:26

Mierunski added the DNM This PR should not be merged (Do Not Merge) label Apr 30, 2020

zephyrbot added the area: Modules label Apr 30, 2020

sigurdnev reviewed May 2, 2020

View reviewed changes

dts/arm/nordic/nrf52820.dtsi Outdated Show resolved Hide resolved

Mierunski force-pushed the nrf52820_support branch from bef7e4c to e2a18d9 Compare May 4, 2020 07:39

lemrey reviewed May 4, 2020

View reviewed changes

boards/arm/nrf52833dk_nrf52820/Kconfig.board Outdated Show resolved Hide resolved

boards/arm/nrf52833dk_nrf52820/nrf52833dk_nrf52820.dts Outdated Show resolved Hide resolved

anangl requested changes May 4, 2020

View reviewed changes

anangl reviewed May 4, 2020

View reviewed changes

dts/arm/nordic/nrf52820.dtsi Outdated Show resolved Hide resolved

dts/arm/nordic/nrf52820.dtsi Outdated Show resolved Hide resolved

dts/arm/nordic/nrf52820.dtsi Outdated Show resolved Hide resolved

nvlsianpu suggested changes May 4, 2020

View reviewed changes

boards/arm/nrf52833dk_nrf52820/nrf52833dk_nrf52820.dts Outdated Show resolved Hide resolved

Mierunski force-pushed the nrf52820_support branch from e2a18d9 to 361778e Compare May 4, 2020 14:08

carlescufi reviewed May 4, 2020

View reviewed changes

west.yml Outdated Show resolved Hide resolved

Mierunski force-pushed the nrf52820_support branch from 361778e to a1f7161 Compare May 4, 2020 14:45

sigurdnev reviewed May 4, 2020

View reviewed changes

dts/arm/nordic/nrf52820.dtsi Outdated Show resolved Hide resolved

soc/arm/nordic_nrf/nrf52/Kconfig.soc Outdated Show resolved Hide resolved

soc/arm/nordic_nrf/nrf52/Kconfig.soc Outdated Show resolved Hide resolved

Mierunski force-pushed the nrf52820_support branch from a1f7161 to b50ab8b Compare May 6, 2020 07:26

Mierunski requested review from cvinayak and thoh-ot as code owners May 6, 2020 10:40

anangl reviewed May 6, 2020

View reviewed changes

dts/arm/nordic/nrf52820.dtsi Outdated Show resolved Hide resolved

zephyrbot added the area: Bluetooth label May 6, 2020

ioannisg suggested changes May 6, 2020

View reviewed changes

Mierunski force-pushed the nrf52820_support branch from 353f06e to 0b4f1e4 Compare May 6, 2020 13:29

nvlsianpu reviewed May 6, 2020

View reviewed changes

nvlsianpu approved these changes May 6, 2020

View reviewed changes

Mierunski force-pushed the nrf52820_support branch 2 times, most recently from 18dacdc to 9cdc491 Compare May 8, 2020 09:04

anangl mentioned this pull request May 8, 2020

Integrate nrfx 2 2 0 zephyrproject-rtos/hal_nordic#37

Merged

Mierunski force-pushed the nrf52820_support branch from 9cdc491 to 2ec48a8 Compare May 8, 2020 10:40

hal: nrf: Integrate nRFX 2.2.0 release

20872d1

Change west.yml nordic hal module to point to 2.2.0 nrfx version. Signed-off-by: Mieszko Mierunski <[email protected]>

Mierunski force-pushed the nrf52820_support branch from 2ec48a8 to 789c9bb Compare May 8, 2020 10:45

ioannisg reviewed May 8, 2020

View reviewed changes

soc/arm/nordic_nrf/nrf52/Kconfig.defconfig.nrf52820_QDAA Outdated Show resolved Hide resolved

Mierunski force-pushed the nrf52820_support branch from 789c9bb to 72a3ab8 Compare May 8, 2020 10:51

Mierunski added 3 commits May 8, 2020 12:52

soc: nordic: Add support for nRF52820

443970c

This commit adds basic support for nRF52820 SoC. Changes affect introducing: - architecuture files (dtsi) - configuration of nrfx drivers - adaptation of inclusions based on chosen SoC Signed-off-by: Mieszko Mierunski <[email protected]>

bluetooth: Add bluetooth support for nRF52820

72a3ab8

This commit adds support for bluetooth in nRF52820 SoC. Bluetooth radio related files created and added to Zephyr. Signed-off-by: Mieszko Mierunski <[email protected]>

ioannisg approved these changes May 8, 2020

View reviewed changes

anangl approved these changes May 8, 2020

View reviewed changes

Mierunski removed the DNM This PR should not be merged (Do Not Merge) label May 8, 2020

ioannisg requested review from lemrey and rlubos May 8, 2020 12:20

rlubos approved these changes May 8, 2020

View reviewed changes

ioannisg merged commit f93924c into zephyrproject-rtos:master May 8, 2020

Mierunski deleted the nrf52820_support branch May 11, 2020 09:25

nrf: Add support for nrf52820 #24816

nrf: Add support for nrf52820 #24816

Uh oh!

Conversation

Mierunski commented Apr 29, 2020

Uh oh!

zephyrbot commented Apr 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

checkpatch (informational only, not a failure)

Uh oh!

anangl commented Apr 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carlescufi commented May 4, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ioannisg left a comment

Choose a reason for hiding this comment

Uh oh!

carlescufi commented May 6, 2020

Uh oh!

nvlsianpu May 4, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ioannisg left a comment

Choose a reason for hiding this comment

Uh oh!

Mierunski commented May 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

zephyrbot commented Apr 29, 2020 •

edited

Loading

anangl commented Apr 29, 2020 •

edited

Loading