[TOPIC-GPIO] sensors: adt7420: update to new GPIO API #21559
Conversation
pabigot
requested review from
MaureenHelm,
dbkinder and
galak
as code owners
pabigot
force-pushed
the
gpio/adt7420
branch
from
98e3099 to
ad211e2
Compare
samples/sensor/adt7420/README.rst
Outdated
There was a problem hiding this comment.
I'm not sure which doc changes are going to win since I see doc changes here and in #21558.
|
DNM until #21558 is merged to master and the topic branch has been rebased on it. |
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
MaureenHelm
dismissed
dbkinder’s stale review
doc changes no longer part of this PR
drivers/sensor/adt7420/adt7420.h
Outdated
There was a problem hiding this comment.
int_label as a name is not very meaningful. drivers/sensor/lsm6dso/lsm6dso_trigger.c is using int_gpio_port, other drivers tend to use _name, not _label. Let's use one of the existing conventions. Otherwise, if we prefer to use a new one, let's come up with a better naming scheme.
There was a problem hiding this comment.
There is no consistency, but _name seems to be somewhat more common than others when referring to a specific signal, so I've added this sensor to that group.
Update sample overlays. Add GPIO flags to configuration state. Refactor to split out setup/handle/process phases. Switch to new API replacing callback dis/enable with interrupt dis/enable. Signed-off-by: Peter Bigot <[email protected]>
5 participants
This PR includes #21558, which should disappear when that PR is merged and the topic branch is rebased. Only the last commit in the series is specific to the new API.