samples: sensor: adt7420: correct devicetree and improve sample #21558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabigot
force-pushed
the
nordic/20191221b
branch
2 times, most recently
from
2aa3d08 to
4a1d2bb
Compare
dbkinder
previously requested changes
Dec 23, 2019
samples/sensor/adt7420/README.rst
Outdated
Contributor
There was a problem hiding this comment.
change to:
... a |plusminus| 1 |deg| C window ...
The device address can only be 0x48 through 0x1B. C6 is connected to the FXOS870 and is not exposed on a header: switch to Arduino D0. Move this to a boards subdirectory so we can add other overlays without cluttering the root. Signed-off-by: Peter Bigot <[email protected]>
Expand the set of hardware this can be tested with. Signed-off-by: Peter Bigot <[email protected]>
When a trigger was enabled the original implementation would do nothing more than print "Waiting for a threshold event", without describing what such an event would look like. Rework to maintain a window of +/- 0.5 Cel around the most recent in-window temperature, and reset that window whenever a trigger occurs or a non-trigger reading is outside the window. Time-out and display the temperature if no event occurs in a reasonable time. Signed-off-by: Peter Bigot <[email protected]>
pabigot
force-pushed
the
nordic/20191221b
branch
from
4a1d2bb to
aaa774a
Compare
MaureenHelm
requested changes
Jan 3, 2020
| reg = <0x48>; | ||
| label = "ADT7420"; | ||
| int-gpios = <&gpioc 6 0>; | ||
| int-gpios = <&gpioc 16 0>; |
Member
There was a problem hiding this comment.
Let's replace with <&arduino_header 6 0> /* D0 */.
Contributor
Author
There was a problem hiding this comment.
Makes sense, but this propagated from the original conversion to devicetree, and isn't specific to this sample: there are at least twelve samples that bypass the Ardunio alias and nexus map for this platform, probably more that do it for other platforms.
Can we do this in a separate PR that fixes it for all samples at once, after the dust settles on topic-gpio and it won't create conflicts?
| */ | ||
|
|
||
| &i2c1 { | ||
| &i2c0 { |
Member
There was a problem hiding this comment.
Let's replace with arduino_i2c
| compatible = "adi,adt7420"; | ||
| reg = <0x48>; | ||
| label = "ADT7420"; | ||
| int-gpios = <&gpio0 11 0>; |
MaureenHelm
approved these changes
Jan 3, 2020
carlescufi
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frdm_k64f devicetree overlay specified the wrong (probably) I2C bus, device address, and pin for the alert signal. Fix that.
Add an overlay for the nrf52_pca10040.
Update the sample so that it can be used for testing triggered alerts.
FWIW: As far as I can tell the alert infrastructure does not work correctly: the sensor seems to never indicate an out-of-window temperature, whether in the status register or through the
INTnorCTnsignals. The MCU-side trigger detection has been tested with manual jiggling of the signal level.