sensors: dht: convert to devicetree and add sample #21424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
pabigot
force-pushed
the
pabigot/20191216b
branch
from
db9670b to
0bf9b3b
Compare
zephyrbot
added
the
area: Tests
pabigot
force-pushed
the
pabigot/20191216b
branch
2 times, most recently
from
0e5d5e7 to
78a847e
Compare
dbkinder
suggested changes
Dec 17, 2019
samples/sensor/dht/README.rst
Outdated
Contributor
There was a problem hiding this comment.
This would read better:
After providing a devicetree overlay that specifies the sensor location, build this sample app using:
78a847e to
d63680f
Compare
MaureenHelm
requested changes
Dec 18, 2019
Member
MaureenHelm
left a comment
MaureenHelm
left a comment
There was a problem hiding this comment.
one nit, but otherwise looks great. thanks @pabigot
drivers/sensor/dht/dht.c
Outdated
Member
There was a problem hiding this comment.
you amended the wrong commit. the change should be in sensor: dht: convert from Kconfig to devicetree
Contributor
Author
There was a problem hiding this comment.
Moved to the right commit.
pabigot
force-pushed
the
pabigot/20191216b
branch
from
d63680f to
acb969e
Compare
Define a binding for the Aosong DHT family of temperature/humidity sensors. Remove the Kconfig settings, and update the driver to use devicetree information. Signed-off-by: Peter Bigot <[email protected]>
Add a sample to test the Aosong temperature/humidity sensor. Signed-off-by: Peter Bigot <[email protected]>
pabigot
force-pushed
the
pabigot/20191216b
branch
from
acb969e to
f5aece4
Compare
MaureenHelm
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a binding for the Aosong DHT family of temperature/humidity sensors. Remove the Kconfig settings, and update the driver to use devicetree information.
Add a sample.