drivers: spi: Add basic Gecko SPI driver #20194

chrta · 2019-10-28T17:02:24Z

This pull request adds SPI driver and its bindings using the USART peripheral for Silicon Labs EFM32 and EFR32 MCUs. It is a very basic driver which uses polling.

To actually use this driver, the SPI interface to the on-board flash MX25R8035F on the board efr32mg_sltb004a is also added.

The driver was tested by running the sample samples/drivers/spi_flash.

zephyrbot · 2019-10-28T17:04:57Z

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

tbursztyka · 2019-10-28T17:06:44Z

drivers/spi/spi_gecko.c

tiny style issue, get an empty line before the if (it's valid if only the previously assigned variable is tested in the if)

dbkinder · 2019-10-28T18:04:16Z

boards/arm/efr32mg_sltb004a/doc/index.rst

 +-----------+------------+-------------------------------------+
 | I2C       | on-chip    | i2c port-polling                    |
 +-----------+------------+-------------------------------------+
+| SPI(M)    | on-chip    | spi port-polling                    |


What's the significance of the (M) notation? Master? Can this just be SPI or if the M is important it should be explained?

Yes, it means master. Slave-mode is not implemented by this driver. I copied the notation from https://docs.zephyrproject.org/latest/boards/arm/nrf52840_pca10059/doc/index.html#supported-features which contains SPI (M/S).
I do not know what the preferred way for this is. I can also remove the (M).

If you think technical folks will know what this means, then it's OK by me. Otherwise, maybe say ```SPI Master`` to be clear.

pabigot

I get the following with builds. Seems like some extra checking that isn't quite right in this case (@ulfalizer?).

-- Loading /mnt/devel/external/zp/zephyr/boards/arm/efr32mg_sltb004a/efr32mg_sltb004a.dts as base
efr32mg_sltb004a.dts.pre.tmp:73.26-81.5: Warning (spi_bus_bridge): /soc/usart@40010800: node name for SPI buses should be 'spi'
  also defined at efr32mg_sltb004a.dts.pre.tmp:280.9-298.3
efr32mg_sltb004a.dts_compiled: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge'

If you go into samples/drivers/spi_flash/boards and copy one of the existing conf files to efr32mg_sltb004a.conf this will verify the flash. It works for me.

I also added configuration to tests/subsys/fs/littlefs and confirmed to my satisfaction that it would work, except that this flash is too small to support the three test partitions the test assumes. Once this goes in I can update it to skip the large partition.

mnkp

@chrta Thanks, looks good with some minor comments. If you are willing to add support also for efr32_slwstk6061a board I will be happy to test it.

dts/bindings/spi/silabs,gecko-usart-spi.yaml

drivers/spi/spi_gecko.c

chrta · 2019-11-11T09:56:59Z

@mnkp Thanks for your review. I addressed all your comments and also added (untested) support for the efr32_slwstk6061a board.

tbursztyka

Looks ok to me on driver side

mnkp

@chrta Thanks, works very well! Verified on efr32_slwstk6061a board.

mnkp · 2019-11-12T00:03:42Z

Actually, I have one more comment. Since Default board configuration guidelines generally require to configure all major components available on the evaluation board maybe we should ensure that spi_nor driver is enabled if flash subsystem is enabled. We could add respective section to the board configuration file, as in boards/arm/efr32_slwstk6061a/Kconfig.defconfig. Doing it manually is a bit tedious and may not be obvious to the new users.

chrta · 2019-11-12T07:38:16Z

Doing it manually is a bit tedious and may not be obvious to the new users.

I agree. Since no other board is doing it, i did not do it either. I would now add this to the Kconfig.defconfig of the two efr boards, ok @mnkp ?

if SPI_GECKO

config SPI_NOR
       default y

endif # SPI_GECKO

chrta · 2019-11-14T07:13:21Z

This pull request now targets master branch. I also cleaned up the reviewers that were added automatically by github .

boards/arm/efr32_slwstk6061a/efr32_slwstk6061a_defconfig

chrta · 2019-12-17T11:10:21Z

@galak Is this now ready to merge?

MaureenHelm

please fix the checkpatch warnings

chrta · 2019-12-19T15:04:32Z

please fix the checkpatch warnings

This is the code that produces the warning:

#ifndef CONFIG_SOC_GECKO_HAS_INDIVIDUAL_PIN_LOCATION
#error "This EFM32 USART SPI driver is only implemented for devices that \
 support individual pin locations"
#endif

Could you suggest a fix. I could also write "Not implemented for this SoC", but it is less detailed.

MaureenHelm · 2020-01-09T22:22:39Z

please fix the checkpatch warnings

This is the code that produces the warning:
#ifndef CONFIG_SOC_GECKO_HAS_INDIVIDUAL_PIN_LOCATION
#error "This EFM32 USART SPI driver is only implemented for devices that \
 support individual pin locations"
#endif
Could you suggest a fix. I could also write "Not implemented for this SoC", but it is less detailed.

How about: "Individual pin location support is required"

This commit adds SPI driver and its bindings using the USART peripheral for Silicon Labs EFM32 and EFR32 MCUs. Signed-off-by: Christian Taedcke <[email protected]>

This commit adds support for the on-board flash MX25R8035F that is directly connected to the efr32mg soc. Signed-off-by: Christian Taedcke <[email protected]>

This commit adds support for the on-board flash MX25R8035F that is directly connected to the efr32fg soc. Signed-off-by: Christian Taedcke <[email protected]>

chrta · 2020-01-10T08:52:16Z

@MaureenHelm Changed error message to your suggestion.

chrta · 2020-01-10T09:55:21Z

Shippable failed because of some unrelated failed test. I also rebased this pr onto the current master. The failed test:

2020-01-10 09:36:23,730 - INFO - 814/814 qemu_x86_64               tests/lib/mem_alloc/libraries.libc.minimal.mem_alloc FAILED Exited with 1 (qemu)

chrta added area: SPI SPI bus area: Boards area: Devicetree DNM This PR should not be merged (Do Not Merge) platform: Silabs Silicon Labs labels Oct 28, 2019

chrta requested review from MaureenHelm, dbkinder, galak, ioannisg and tbursztyka as code owners October 28, 2019 17:02

chrta requested a review from mnkp October 28, 2019 17:02

chrta added the area: Drivers label Oct 28, 2019

chrta mentioned this pull request Oct 28, 2019

[TOPIC-GPIO] gpio: gecko: Add init macro and support for more ports #20181

Merged

tbursztyka reviewed Oct 28, 2019

View reviewed changes

chrta force-pushed the efm32_add_spi branch from cf62bf5 to 765dfb3 Compare October 28, 2019 17:11

dbkinder suggested changes Oct 28, 2019

View reviewed changes

pabigot reviewed Oct 28, 2019

View reviewed changes

chrta force-pushed the efm32_add_spi branch 2 times, most recently from eb85a8f to 8cf0bda Compare October 29, 2019 08:33

dbkinder approved these changes Nov 1, 2019

View reviewed changes

chrta removed the DNM This PR should not be merged (Do Not Merge) label Nov 4, 2019

carlescufi mentioned this pull request Nov 5, 2019

Convert GPIO users to new GPIO API #20017

Closed

mnkp reviewed Nov 10, 2019

View reviewed changes

chrta force-pushed the efm32_add_spi branch from 8cf0bda to 895cff3 Compare November 11, 2019 09:54

tbursztyka approved these changes Nov 11, 2019

View reviewed changes

mnkp approved these changes Nov 11, 2019

View reviewed changes

zephyrbot added area: Sensors Sensors area: Timer Timer area: ARC ARC Architecture area: Settings Settings subsystem area: File System area: Samples Samples area: Documentation labels Nov 14, 2019

chrta removed area: ARC ARC Architecture area: File System area: Samples Samples area: Sensors Sensors area: Settings Settings subsystem area: Timer Timer labels Nov 14, 2019

chrta mentioned this pull request Nov 14, 2019

Clarification: How to enable on-board nor-flash following the board porting guide? #20687

Closed

mnkp reviewed Nov 18, 2019

View reviewed changes

boards/arm/efr32_slwstk6061a/efr32_slwstk6061a_defconfig Outdated Show resolved Hide resolved

chrta force-pushed the efm32_add_spi branch from 30783d3 to f0605bc Compare November 19, 2019 10:09

MaureenHelm requested changes Dec 18, 2019

View reviewed changes

chrta added 3 commits January 10, 2020 09:42

drivers: spi: Add Gecko SPI driver

d4231b1

This commit adds SPI driver and its bindings using the USART peripheral for Silicon Labs EFM32 and EFR32 MCUs. Signed-off-by: Christian Taedcke <[email protected]>

boards: efr32mg_sltb004a: Add support for spi nor flash

e4dd8f5

This commit adds support for the on-board flash MX25R8035F that is directly connected to the efr32mg soc. Signed-off-by: Christian Taedcke <[email protected]>

boards: efr32_slwstk6061a: Add support for spi nor flash

2a1c8c7

This commit adds support for the on-board flash MX25R8035F that is directly connected to the efr32fg soc. Signed-off-by: Christian Taedcke <[email protected]>

chrta force-pushed the efm32_add_spi branch from f0605bc to 2a1c8c7 Compare January 10, 2020 08:50

MaureenHelm approved these changes Jan 10, 2020

View reviewed changes

MaureenHelm merged commit 20aa2bc into master Jan 10, 2020

MaureenHelm deleted the efm32_add_spi branch January 10, 2020 13:14

drivers: spi: Add basic Gecko SPI driver #20194

drivers: spi: Add basic Gecko SPI driver #20194

Uh oh!

Conversation

chrta commented Oct 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zephyrbot commented Oct 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tbursztyka Oct 28, 2019

Choose a reason for hiding this comment

Uh oh!

chrta Oct 29, 2019

Choose a reason for hiding this comment

Uh oh!

dbkinder Oct 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chrta Oct 29, 2019

Choose a reason for hiding this comment

Uh oh!

dbkinder Nov 1, 2019

Choose a reason for hiding this comment

Uh oh!

pabigot left a comment

Choose a reason for hiding this comment

Uh oh!

mnkp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chrta commented Nov 11, 2019

Uh oh!

tbursztyka left a comment

Choose a reason for hiding this comment

Uh oh!

mnkp left a comment

Choose a reason for hiding this comment

Uh oh!

mnkp commented Nov 12, 2019

Uh oh!

chrta commented Nov 12, 2019

Uh oh!

chrta commented Nov 14, 2019

Uh oh!

Uh oh!

chrta commented Dec 17, 2019

Uh oh!

MaureenHelm left a comment

Choose a reason for hiding this comment

Uh oh!

chrta commented Dec 19, 2019

Uh oh!

MaureenHelm commented Jan 9, 2020

Uh oh!

chrta commented Jan 10, 2020

Uh oh!

chrta commented Jan 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

chrta commented Oct 28, 2019 •

edited

Loading

zephyrbot commented Oct 28, 2019 •

edited

Loading

dbkinder Oct 28, 2019 •

edited

Loading