Skip to content

Conversation

@chrta
Copy link
Contributor

@chrta chrta commented Oct 28, 2019

This introduces a macro to initialize gpio ports to the gecko gpio driver. This macro simplified adding support for port g to port k.
These ports are also added to the efr32mg12p soc dtsi file.
Port k will actually be used in the pull request #20194 which adds a basic spi driver to the efr32mg board that connects to a spi nor flash.

@zephyrbot
Copy link

zephyrbot commented Oct 28, 2019

All checks passed.

checkpatch (informational only, not a failure)

-:281: WARNING:LONG_LINE: line over 80 characters
#281: FILE: soc/arm/silabs_exx32/efr32mg12p/dts_fixup.h:29:
+#define DT_GPIO_GECKO_PORTI_NAME	DT_SILABS_EFR32MG_GPIO_PORT_4000A180_LABEL

-:282: WARNING:LONG_LINE: line over 80 characters
#282: FILE: soc/arm/silabs_exx32/efr32mg12p/dts_fixup.h:30:
+#define DT_GPIO_GECKO_PORTJ_NAME	DT_SILABS_EFR32MG_GPIO_PORT_4000A1B0_LABEL

-:283: WARNING:LONG_LINE: line over 80 characters
#283: FILE: soc/arm/silabs_exx32/efr32mg12p/dts_fixup.h:31:
+#define DT_GPIO_GECKO_PORTK_NAME	DT_SILABS_EFR32MG_GPIO_PORT_4000A1E0_LABEL

- total: 0 errors, 3 warnings, 265 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@galak
Copy link
Contributor

galak commented Oct 28, 2019

Its probably best this was done against the 'topic-gpio' branch.

@chrta chrta changed the base branch from master to topic-gpio October 28, 2019 11:28
@chrta chrta changed the base branch from topic-gpio to master October 28, 2019 11:28
@chrta
Copy link
Contributor Author

chrta commented Oct 28, 2019

@galak OK, i will change the target branch to topic-gpio

chrta added 2 commits October 28, 2019 12:36
This removes a lot of copy-and-paste.

Signed-off-by: Christian Taedcke <[email protected]>
The gecko gpio driver can now utilize ports a to k.

Signed-off-by: Christian Taedcke <[email protected]>
@chrta chrta removed area: Samples Samples area: Sensors Sensors area: Tests Issues related to a particular existing or missing test labels Oct 28, 2019
@galak
Copy link
Contributor

galak commented Oct 28, 2019

Sorry, because of the branch changes, a lot of reviewers were requested automatically. Should i delete them manually?
Now the target branch is topic-gpio.

I updated the reviewers list.

@galak galak changed the title gpio: gecko: Add init macro and support for more ports [TOPIC-GPIO] gpio: gecko: Add init macro and support for more ports Oct 28, 2019
Add device tree elements for all gpio ports of the efr32mg12p including
the dts fixup entries.
Also remove gpio port e since this is not available in efr32mg12p socs.

Signed-off-by: Christian Taedcke <[email protected]>
@galak galak merged commit c3c1e6b into topic-gpio Nov 4, 2019
@chrta chrta deleted the efm32_more_gpios branch November 4, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants