sensor: lsm6dsl: sample and driver fixes #19866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sensor defaults to no trigger, in which case no observations will be read from the device. Set to use the work queue (global) trigger. Signed-off-by: Peter Bigot <[email protected]>
The function that initializes interrupts configures the sensor register to enable interrupts. It is called before the function that resets the sensor. Swap the order. Also correct the mask argument to the configuration command, and use the BIT() macro to construct the set argument. Signed-off-by: Peter Bigot <[email protected]>
Contributor
|
@pabigot |
Contributor
Author
|
MaureenHelm
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample program did nothing by default because no triggers were configured.
By inspection the driver mis-ordered some initialization code, and mis-configured a register. It is unclear to me why it worked before, since the power-up reset value of the register is to not enable interrupts.
Tested on
frdm_k64fandnucleo_l476rgwithx_nucleo_iks01a2shield.