[TOPIC-GPIO] drivers: sensor: lsm6dsl: update to new GPIO API #19839

pabigot · 2019-10-15T18:16:10Z

Correct IRQ active level to default active-low, switch to new interrupt configuration.

Tested with frdm_k64f and nucleo_l476rg with x-nucleo-iks01a2.

NOTE This is based on #19862, #19866, and #19870 on which it depends. It's DNM solely for those inclusions.

zephyrbot · 2019-10-15T18:31:10Z

All checks passed.

checkpatch (informational only, not a failure)

-:89: WARNING:LONG_LINE: line over 80 characters
#89: FILE: drivers/sensor/lsm6dsl/lsm6dsl_trigger.c:59:
+	if (gpio_pin_get(drv_data->gpio, DT_INST_0_ST_LSM6DSL_IRQ_GPIOS_PIN) > 0) {

- total: 0 errors, 1 warnings, 140 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

erwango · 2019-10-16T07:50:07Z

@pabigot, can't get it work on disco_l475_iot1 (working on master).
Tested on #19579 + current PR.
Not much time right now for analysis, but if that can help, here is a back trcae of the issue:

0x080055d6 in LL_I2C_IsActiveFlag_ARLO (I2Cx=0x40005800) at /local/mcu/zephyr/modules/hal/stm32/stm32cube/stm32l4xx/drivers/include/stm32l4xx_ll_i2c.h:1630
1630	  return ((READ_BIT(I2Cx->ISR, I2C_ISR_ARLO) == (I2C_ISR_ARLO)) ? 1UL : 0UL);
(gdb) bt
#0  0x080055d6 in LL_I2C_IsActiveFlag_ARLO (I2Cx=0x40005800) at /local/mcu/zephyr/modules/hal/stm32/stm32cube/stm32l4xx/drivers/include/stm32l4xx_ll_i2c.h:1630
#1  check_errors (funcname=<optimized out>, dev=<optimized out>) at /local/mcu/zephyr/zephyr-project/drivers/i2c/i2c_ll_stm32_v2.c:488
#2  0x080056f2 in stm32_i2c_msg_read (dev=0x2000170c <__device_i2c_stm32_I2C_2>, msg=0x200014d4 <sys_work_q_stack+916>, next_msg_flags=<optimized out>, slave=<optimized out>)
    at /local/mcu/zephyr/zephyr-project/drivers/i2c/i2c_ll_stm32_v2.c:581
#3  0x080057fe in i2c_stm32_transfer (dev=0x2000170c <__device_i2c_stm32_I2C_2>, msg=<optimized out>, num_msgs=1 '\001', slave=<optimized out>) at /local/mcu/zephyr/zephyr-project/drivers/i2c/i2c_ll_stm32.c:142
#4  0x08005a8c in z_impl_i2c_transfer (addr=106, num_msgs=2 '\002', msgs=0x200014c8 <sys_work_q_stack+904>, dev=<optimized out>) at ../../../../../include/drivers/i2c.h:252
#5  i2c_transfer (addr=106, num_msgs=2 '\002', msgs=0x200014c8 <sys_work_q_stack+904>, dev=<optimized out>) at zephyr/include/generated/syscalls/i2c.h:46
#6  i2c_write_read (num_write=1, num_read=<optimized out>, read_buf=<optimized out>, write_buf=0x200014c7 <sys_work_q_stack+903>, addr=106, dev=<optimized out>) at ../../../../../include/drivers/i2c.h:454
#7  i2c_burst_read (num_bytes=<optimized out>, buf=<optimized out>, start_addr=<optimized out>, dev_addr=106, dev=<optimized out>) at ../../../../../include/drivers/i2c.h:480
#8  lsm6dsl_i2c_read_data (data=<optimized out>, reg_addr=<optimized out>, value=<optimized out>, len=<optimized out>) at /local/mcu/zephyr/zephyr-project/drivers/sensor/lsm6dsl/lsm6dsl_i2c.c:26
#9  0x0800582e in lsm6dsl_sample_fetch_accel (dev=<optimized out>) at /local/mcu/zephyr/zephyr-project/drivers/sensor/lsm6dsl/lsm6dsl.c:321
#10 0x080058d4 in lsm6dsl_sample_fetch (dev=0x2000173c <__device_lsm6dsl>, chan=<optimized out>) at /local/mcu/zephyr/zephyr-project/drivers/sensor/lsm6dsl/lsm6dsl.c:423
#11 0x080017d6 in z_impl_sensor_sample_fetch_chan (type=SENSOR_CHAN_ACCEL_XYZ, dev=0x2000173c <__device_lsm6dsl>) at /local/mcu/zephyr/zephyr-project/include/drivers/sensor.h:439
#12 sensor_sample_fetch_chan (type=SENSOR_CHAN_ACCEL_XYZ, dev=0x2000173c <__device_lsm6dsl>) at zephyr/include/generated/syscalls/sensor.h:59
#13 lsm6dsl_trigger_handler (dev=0x2000173c <__device_lsm6dsl>, trig=<optimized out>) at ../../src/main.c:44
#14 0x08005ac6 in lsm6dsl_thread_cb (arg=<optimized out>) at /local/mcu/zephyr/zephyr-project/drivers/sensor/lsm6dsl/lsm6dsl_trigger.c:85
#15 lsm6dsl_work_cb (work=<optimized out>) at /local/mcu/zephyr/zephyr-project/drivers/sensor/lsm6dsl/lsm6dsl_trigger.c:113
#16 0x08004ce2 in z_work_q_main (work_q_ptr=0x2000037c <k_sys_work_q>, p2=<optimized out>, p3=<optimized out>) at /local/mcu/zephyr/zephyr-project/lib/os/work_q.c:32
#17 0x08004ca2 in z_thread_entry (entry=0x8004cab <z_work_q_main>, p1=<optimized out>, p2=<optimized out>, p3=<optimized out>) at /local/mcu/zephyr/zephyr-project/lib/os/thread_entry.c:29
#18 0x08004ca2 in z_thread_entry (entry=0x8004cab <z_work_q_main>, p1=<optimized out>, p2=<optimized out>, p3=<optimized out>) at /local/mcu/zephyr/zephyr-project/lib/os/thread_entry.c:29
#19 0x08001cb8 in stm32_exti_unset_callback (line=134244516) at /local/mcu/zephyr/zephyr-project/drivers/interrupt_controller/exti_stm32.c:406

pabigot · 2019-10-16T16:38:00Z

@erwango Sorry, that was a simple error of re-invoking the fetch operation instead of re-enabling the interrupt once the worker completed. Should work now.

drivers/sensor/lsm6dsl/lsm6dsl_trigger.c

avisconti · 2019-12-05T11:48:12Z

boards/arm/96b_argonkey/96b_argonkey.dts

I already addressed it in #21203. I think it is the proper place (96b_argonkey changes)

But can be done also in this commit honestly.
What do you think?

I don't care where it's done. I'll leave it in here for now, there should be no conflict no matter which gets merged first.

@avisconti Do you have objections to this PR other than that it updates the devicetree binding that it depends on? I don't think I can remove that, unless #21203 is merged first and then this is rebased on it.

@avisconti Do you have objections to this PR other than that it updates the devicetree binding that it depends on? I don't think I can remove that, unless #21203 is merged first and then this is rebased on it.

Sure.

dbkinder

doc change LGTM

avisconti

No, it is good!

MaureenHelm

Please update the commit message to say active high rather than active low.

Correct IRQ active level to default active-high, switch to new interrupt configuration. Signed-off-by: Peter Bigot <[email protected]>

pabigot · 2019-12-13T22:55:18Z

Please update the commit message to say active high rather than active low.

Done.

pabigot added area: GPIO area: Sensors Sensors labels Oct 15, 2019

pabigot requested review from avisconti and erwango as code owners October 15, 2019 18:16

pabigot changed the title ~~drivers: sensor: lsm6dsl: update to new GPIO API~~ [TOPIC-GPIO] drivers: sensor: lsm6dsl: update to new GPIO API Oct 15, 2019

zephyrbot added the area: Boards label Oct 15, 2019

pabigot added the DNM This PR should not be merged (Do Not Merge) label Oct 16, 2019

pabigot force-pushed the gpio/lsm6dsl branch from b73ffd2 to 99644f1 Compare October 16, 2019 16:34

pabigot requested review from MaureenHelm, bogdan-davidoaia, carlescufi, galak, ioannisg, lemrey and rsalveti as code owners October 16, 2019 16:34

zephyrbot added area: Devicetree area: Samples Samples labels Oct 16, 2019

pabigot force-pushed the gpio/lsm6dsl branch from 99644f1 to b34da29 Compare October 16, 2019 17:53

pabigot requested a review from nashif as a code owner October 16, 2019 17:53

zephyrbot added the area: Tests Issues related to a particular existing or missing test label Oct 16, 2019

mnkp reviewed Oct 17, 2019

View reviewed changes

drivers/sensor/lsm6dsl/lsm6dsl_trigger.c Outdated Show resolved Hide resolved

carlescufi mentioned this pull request Oct 22, 2019

Convert GPIO users to new GPIO API #20017

Closed

galak force-pushed the topic-gpio branch from 315246d to 653e004 Compare October 25, 2019 12:55

galak force-pushed the gpio/lsm6dsl branch from b34da29 to 3bd941c Compare October 25, 2019 12:58

galak force-pushed the topic-gpio branch from 653e004 to 2222ac6 Compare October 25, 2019 16:16

galak force-pushed the gpio/lsm6dsl branch from 3bd941c to 92da556 Compare October 25, 2019 23:12

galak force-pushed the topic-gpio branch from 1097995 to a205c54 Compare November 13, 2019 18:09

galak force-pushed the gpio/lsm6dsl branch from 92da556 to 6a60825 Compare November 13, 2019 18:12

avisconti requested changes Dec 5, 2019

View reviewed changes

pabigot force-pushed the gpio/lsm6dsl branch from 6a60825 to 2b8350e Compare December 9, 2019 17:15

pabigot requested a review from dbkinder as a code owner December 9, 2019 17:15

avisconti mentioned this pull request Dec 10, 2019

sample/sensortile_box: update to the new GPIO API #20941

Merged

dbkinder approved these changes Dec 10, 2019

View reviewed changes

pabigot removed the DNM This PR should not be merged (Do Not Merge) label Dec 13, 2019

avisconti approved these changes Dec 13, 2019

View reviewed changes

pabigot force-pushed the gpio/lsm6dsl branch from 2b8350e to 260deeb Compare December 13, 2019 21:07

mnkp approved these changes Dec 13, 2019

View reviewed changes

MaureenHelm requested changes Dec 13, 2019

View reviewed changes

drivers: sensor: lsm6dsl: update to new GPIO API

b65d799

Correct IRQ active level to default active-high, switch to new interrupt configuration. Signed-off-by: Peter Bigot <[email protected]>

pabigot force-pushed the gpio/lsm6dsl branch from 260deeb to b65d799 Compare December 13, 2019 22:55

MaureenHelm approved these changes Dec 13, 2019

View reviewed changes

carlescufi merged commit 226a9f2 into zephyrproject-rtos:topic-gpio Dec 19, 2019

[TOPIC-GPIO] drivers: sensor: lsm6dsl: update to new GPIO API #19839

[TOPIC-GPIO] drivers: sensor: lsm6dsl: update to new GPIO API #19839

Uh oh!

Conversation

pabigot commented Oct 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zephyrbot commented Oct 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

checkpatch (informational only, not a failure)

Uh oh!

erwango commented Oct 16, 2019

Uh oh!

pabigot commented Oct 16, 2019

Uh oh!

Uh oh!

avisconti Dec 5, 2019

Choose a reason for hiding this comment

Uh oh!

avisconti Dec 5, 2019

Choose a reason for hiding this comment

Uh oh!

pabigot Dec 9, 2019

Choose a reason for hiding this comment

Uh oh!

pabigot Dec 13, 2019

Choose a reason for hiding this comment

Uh oh!

avisconti Dec 13, 2019

Choose a reason for hiding this comment

Uh oh!

dbkinder left a comment

Choose a reason for hiding this comment

Uh oh!

avisconti left a comment

Choose a reason for hiding this comment

Uh oh!

MaureenHelm left a comment

Choose a reason for hiding this comment

Uh oh!

pabigot commented Dec 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

pabigot commented Oct 15, 2019 •

edited

Loading

zephyrbot commented Oct 15, 2019 •

edited

Loading