-
Notifications
You must be signed in to change notification settings - Fork 8.2k
[TOPIC-GPIO] update sam0 driver #19785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All checks passed. checkpatch (informational only, not a failure)Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
|
@mnkp This does not pass the (updated) 1-pin test for interrupts. I believe that's because on SAM0 a pin that is configured for interrupts is set for an alternate pinmux function (EIC) and cannot be set with the GPIO interface. Although I've confirmed that setting and clearing the pin results in a change in the input value before The two pin interrupt tests pass. |
jfischer-no
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on samr21xpro with tests/drivers/gpio/gpio_basic_api, blinky and button samples. ✔️ LGTM
b565bb9 to
6ec3ed4
Compare
SAMD5x/SAME5x header files do not provide this define anymore. On SAMD2x it was 0, this is still valid. Signed-off-by: Benjamin Valentin <[email protected]>
Drop the port access, rework to separate interrupt and pin configuration, add new API. Signed-off-by: Peter Bigot <[email protected]>
Use standard spelling for pull and active flags. Correct LED active level (based on SAM-D21-Xplained-Pro). Signed-off-by: Peter Bigot <[email protected]>
Tested on SAM-D21-Xplained Pro with 2-pin test, blinky, and button.
Checked D20 and R21 data sheets, there should be no incompatibilities.