Skip to content

[TOPIC-GPIO] drivers: gpio_mcux: Fix handling of disconnect configuration #19556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[TOPIC-GPIO] drivers: gpio_mcux: Fix handling of disconnect configuration #19556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions drivers/gpio/gpio_mcux.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,22 +104,25 @@ static int gpio_mcux_configure(struct device *dev,
* 0 - pin is input, 1 - pin is output
*/

/* Treat disconnected ie, (!GPIO_INPUT && !GPIO_OUTPUT) the same
* way we treat GPIO_INPUT, this we aren't driving anything by accident
*/
if (access_op == GPIO_ACCESS_BY_PIN) {
if ((flags & GPIO_INPUT) != 0) {
gpio_base->PDDR &= ~BIT(pin);
} else { /* GPIO_OUTPUT */
if ((flags & GPIO_OUTPUT) != 0) {
if ((flags & GPIO_OUTPUT_INIT_HIGH) != 0) {
gpio_base->PSOR = BIT(pin);
} else if ((flags & GPIO_OUTPUT_INIT_LOW) != 0) {
gpio_base->PCOR = BIT(pin);
}
gpio_base->PDDR |= BIT(pin);
} else { /* GPIO_INPUT or disconnect */
gpio_base->PDDR &= ~BIT(pin);
}
} else { /* GPIO_ACCESS_BY_PORT */
if ((flags & GPIO_INPUT) != 0) {
gpio_base->PDDR = 0x0;
} else { /* GPIO_OUTPUT */
if ((flags & GPIO_OUTPUT) != 0) {
gpio_base->PDDR = 0xFFFFFFFF;
} else { /* GPIO_INPUT or disconnect */
gpio_base->PDDR = 0x0;
}
}

Expand Down