[TOPIC-GPIO] drivers: gpio_mcux: Fix handling of disconnect configuration #19556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the gpio flags are passed such that neither GPIO_INPUT or GPIO_OUTPUT is set, we should treat this as a disconnected state. Change the config code to handle that configuration as a GPIO_INPUT so we aren't accidently driving something on the pin. Signed-off-by: Kumar Gala <[email protected]>
Contributor
Author
|
@MaureenHelm its not clear to me if this change makes sense, or if we should treat |
galak
changed the title
pabigot
reviewed
Oct 2, 2019
Contributor
pabigot
left a comment
pabigot
left a comment
There was a problem hiding this comment.
As I read K64P144M120SF5RM.pdf (section 55.3.2) a pin configured for GPIO must be either an input or an output. If that's true, then -ENOTSUP should be returned unless exactly one of GPIO_INPUT and GPIO_OUTPUT is set.
Based on that I'll have to change the 2-pin test to fall back to setting the output pin as input rather than disconnected.
Contributor
Author
|
Closing this as @pabigot PR makes sense to me. Will leave it up to @MaureenHelm to state otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the gpio flags are passed such that neither GPIO_INPUT or GPIO_OUTPUT
is set, we should treat this as a disconnected state. Change the config
code to handle that configuration as a GPIO_INPUT so we aren't
accidently driving something on the pin.
Signed-off-by: Kumar Gala [email protected]