Skip to content

Conversation

@jukkar
Copy link
Member

@jukkar jukkar commented Jun 13, 2019

Many of the networking PRs are failing in these boards because
of this build error:

ERROR: section nocache is 128 bytes in the virtual/runtime address
space, but only 0 in the loaded/XIP section!

See #16778 for details.

So temporarily disable Ethernet support so that unrelated PRs can
be merged. This should be reverted after the root cause is found
and #16778 is fixed.

Signed-off-by: Jukka Rissanen [email protected]

Many of the networking PRs are failing in these boards because
of this build error:

ERROR: section nocache is 128 bytes in the virtual/runtime address \
space, but only 0 in the loaded/XIP section!

See zephyrproject-rtos#16778 for details.

So temporarily disable Ethernet support so that unrelated PRs can
be merged. This should be reverted after the root cause is found
and zephyrproject-rtos#16778 is fixed.

Signed-off-by: Jukka Rissanen <[email protected]>
Copy link
Contributor

@pfalcon pfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems much harsher workaround than just sticking to platform_whitelist we had for a while. (At the very least, the maintainers should be given some time to react, my -1 serves just that purpose.)

@jukkar
Copy link
Member Author

jukkar commented Jun 13, 2019

We have been agreeing already that the whitelisting in various networking tests should be removed. So if some board is no longer working properly, then we should avoid trying to compile that board. Easiest way is to disable sanitychecker to use that board for networking tests that want ethernet interface.

@pfalcon
Copy link
Contributor

pfalcon commented Jun 13, 2019

So if some board is no longer working properly, then we should avoid trying to compile that board.

You know, I'm a big proponent of such solutions. If you're too, then I wonder why my proposal to disable misbehaving sam_e70_xplained boards wasn't supported for ~half a year?

Easiest way is to disable sanitychecker to use that board for networking tests that want ethernet interface.

That's the problem with this change - the config for this board says that it has Ethernet, and that's true, it has, on hardware level. You change says that it doesn't have Ethernet, which is well, not true. If you want to disable that board by blacklisting it from particular tests, I'm +1 right away.

@pfalcon
Copy link
Contributor

pfalcon commented Jun 13, 2019

You change says that it doesn't have Ethernet, which is well, not true.

And besides, the build failure doesn't even happen because of the Ethernet, it happens with some link-time helper script.

@jukkar
Copy link
Member Author

jukkar commented Jun 13, 2019

I just want to the PRs to progress and get merged. If there is proper fix, that is just fine. I do not want to start to add the whitelists again to multiple PRs if there is a simple and temporary workaround.

@jukkar
Copy link
Member Author

jukkar commented Jun 19, 2019

No need for this as #16923 solves the issue.

@jukkar jukkar closed this Jun 19, 2019
@jukkar jukkar deleted the mimxrt10-disable-ethernet branch February 29, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants