Skip to content

Conversation

@ioannisg
Copy link
Member

@ioannisg ioannisg commented Jun 19, 2019

No-cache SRAM section is currently used for ARM-only builds
with support for no-cacheable memory sections (i.e.
CONFIG_ARCH_HAS_NOCACHE_MEMORY_SUPPORT) and it holds
uninitialized data. This commit properly defines the
corresponding linker section using SECTION_DATA_PROLOGUE
and GROUP_DATA_LINK_IN macros.

The patch fixes mimxrt board compilation.

Fixes #16778

Signed-off-by: Ioannis Glaropoulos [email protected]

No-cache SRAM section is currently used for ARM-only builds
with support for no-cacheable memory sections (i.e.
CONFIG_ARCH_HAS_NOCACHE_MEMORY_SUPPORT) and it holds
uninitialized data. This commit properly defines the
corresponding linker section using SECTION_DATA_PROLOGUE
and GROUP_DATA_LINK_IN macros.

Signed-off-by: Ioannis Glaropoulos <[email protected]>
@ioannisg
Copy link
Member Author

No cache memory sections are currently used only for ARM, and only for Cortex-M7 with MPU support, which is reflected in ARCH_HAS_NOCACHE_MEMORY_SUPPORT.

Currently used for uninitialized data in some drivers like ethernet and usb for nxp and atmel platforms.

Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me, did not see the errors after this PR

@ioannisg ioannisg marked this pull request as ready for review June 19, 2019 09:48
@ioannisg ioannisg added area: ARM ARM (32-bit) Architecture area: Linker Scripts labels Jun 19, 2019
@ioannisg ioannisg requested a review from MaureenHelm June 19, 2019 09:54
Copy link
Contributor

@oyvindronningstad oyvindronningstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me.

@ioannisg ioannisg requested a review from aurel32 June 19, 2019 10:16
Copy link
Contributor

@aurel32 aurel32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@ioannisg ioannisg added this to the v2.0.0 milestone Jun 19, 2019
@andrewboie andrewboie merged commit 6cbc0e0 into zephyrproject-rtos:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ARM ARM (32-bit) Architecture area: Linker Scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failures in various mimxrt boards

6 participants