[DNM][brokencase] Posix zephyr interface library broken inc order #16679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with how newlib headers are treated, and will have effect of ninlibc headers to be further down in the include order. This is important, because some POSIX subsys headers override those of libc. Without this change, we can't streamline POSIX build config using zephyr_interface_library_named() cmake directive, because includes will be in wrong order. Signed-off-by: Paul Sokolovsky <[email protected]>
Similar to how other sub-libraries are defined in Zephyr tree, e.g. "fs", "lgvl", etc. This is supposed to help with the need to explicitly add posix include path to each and every application using POSIX subsys. Fixes: zephyrproject-rtos#15627 Signed-off-by: Paul Sokolovsky <[email protected]>
This is no longer needed after using zephyr_interface_library_named cmake directive in the POSIX subsys source itself. Signed-off-by: Paul Sokolovsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is variant of #15937 without the important "CMakeLists.txt: Call toolchain_cc_nostdinc() at the end" patch, submitted so @SebastianBoe can see the problem that patch fixes.