Skip to content

[DNM][brokencase] Posix zephyr interface library broken inc order #16679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[DNM][brokencase] Posix zephyr interface library broken inc order #16679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5148ad
libc: minimal: Add headers as system includes
pfalcon Jun 6, 2019
24b0e4e
lib: posix: Switch to use zephyr_interface_library_named cmake directive
pfalcon May 6, 2019
f4832e4
tests: posix: No longer use target_include_directories
pfalcon May 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/libc/minimal/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: Apache-2.0

zephyr_include_directories(include)
zephyr_system_include_directories(include)

zephyr_library()
zephyr_library_sources(
Expand Down
2 changes: 1 addition & 1 deletion lib/posix/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: Apache-2.0


add_library(PTHREAD INTERFACE)
zephyr_interface_library_named(PTHREAD)

target_include_directories(PTHREAD INTERFACE ${ZEPHYR_BASE}/include/posix)

Expand Down
8 changes: 8 additions & 0 deletions lib/posix/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,4 +96,12 @@ config POSIX_MAX_OPEN_FILES
endif
endif # FILE_SYSTEM

# The name of this option is mandated by zephyr_interface_library_named
# cmake directive.
config APP_LINK_WITH_PTHREAD
bool "Make POSIX headers available to application"
default y
help
Add POSIX header files to the 'app' include path.

endif # POSIX_API
1 change: 0 additions & 1 deletion tests/posix/common/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,5 @@ cmake_minimum_required(VERSION 3.13.1)
include($ENV{ZEPHYR_BASE}/cmake/app/boilerplate.cmake NO_POLICY_SCOPE)
project(posix_common)

target_include_directories(app PRIVATE $ENV{ZEPHYR_BASE}/include/posix)
FILE(GLOB app_sources src/*.c)
target_sources(app PRIVATE ${app_sources})
2 changes: 0 additions & 2 deletions tests/posix/fs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,5 @@ cmake_minimum_required(VERSION 3.13.1)
include($ENV{ZEPHYR_BASE}/cmake/app/boilerplate.cmake NO_POLICY_SCOPE)
project(fs)

target_include_directories(app PRIVATE $ENV{ZEPHYR_BASE}/include/)

FILE(GLOB app_sources src/*.c)
target_sources(app PRIVATE ${app_sources})